feat: user cannot delete himself from team#357
Open
7eliassen wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
neSpecc
reviewed
Jul 9, 2026
Comment on lines
+42
to
+44
| const menuItems: ContextMenuItem[] = []; | ||
|
|
||
| if (props.teamMember.user.email !== user.value?.email) { |
Member
There was a problem hiding this comment.
make computed property instead, thus we can handle user value change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent a user from removing themselves from the note's team member list.
Changes
The "Remove" context menu item is now only shown for team members whose email does not match the current user's email
The popover button is only shown when there is at least one menu item to display