[codex] Remove web preload wiring from JVM templates#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove generated web preload task wiring from projects that do not include the
webtarget.Why
The CLI was always emitting root Gradle preload wiring for JS/Wasm browser distribution tasks, even when the generated project only configured
jvm(). That left JVM-only templates with misleading web/Wasm task scaffolding.What changed
build.gradle.ktspreload task wiring conditional on the selected targets.webtarget.Impact
JVM-only generated projects no longer contain
composeCompatibilityBrowserDistributionor related JS/Wasm preload wiring unless web support is actually configured.Validation
./gradlew :cli:test --tests com.composables.cli.CliTest./gradlew test./gradlew spotlessCheck