Use new KMP project structure on generated projects#13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shared,androidApp,iosApp,desktopApp, andwebAppwebAppCli.ktby centralizing shared placeholder expansion and Wasm preload task generationandroidx.compose.ui.tooling.preview.Previewwithorg.jetbrains.compose.ui:ui-tooling-previewandroid {}plus direct version-catalog Compose UI dependenciescompileIosMainKotlinMetadataduring project creation so generation stays clean even when upstream native dependency metadata emits duplicate-KLIB warningsVerification
./gradlew test spotlessCheck./gradlew run --args='create-app /tmp/composables-cli-preview4 --package=com.example.preview --app-name=Preview --targets=jvm,android,ios,wasm --overwrite'./gradlew :androidApp:assembleDebug./gradlew :webApp:wasmJsBrowserDistributionNotes
sharedmodule now usesandroidx.compose.ui.tooling.preview.Preview,org.jetbrains.compose.ui:ui-tooling-preview,androidRuntimeClasspath(org.jetbrains.compose.ui:ui-tooling), and the newandroid {}Kotlin Multiplatform Android DSL.compileIosMainKotlinMetadatastill reports duplicate KLIBunique_namewarnings from the native metadata dependency graph behindcom.composables:ui; the generator no longer triggers that task during creation.url.parse()deprecation warning during npm install.