Skip to content

hotfix/ analysis fails silently when cppcheck project file is used #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidramnero merged 1 commit into from
Jul 23, 2026
Merged

hotfix/ analysis fails silently when cppcheck project file is used #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 37 additions & 13 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,12 @@ async function runCppcheckOnFileXML(
continue;
}

const mainLocDocument = await vscode.workspace.openTextDocument(mainLoc.file);
let mainLocDocument : vscode.TextDocument | undefined;
try {
mainLocDocument = await vscode.workspace.openTextDocument(mainLoc.file);
} catch {
// do nothing
}

// Cppcheck line number is 1-indexed, while VS Code uses 0-indexing
let line = Number(mainLoc.line) - 1;
Expand All @@ -378,7 +383,7 @@ async function runCppcheckOnFileXML(

// Cppcheck col number is 1-indexed, while VS Code uses 0-indexing
let col = Number(mainLoc.column) - 1;
if (isNaN(col) || col < 0 || col > mainLocDocument.lineAt(line).text.length) {
if (isNaN(col) || col < 0 || !mainLocDocument || col > mainLocDocument.lineAt(line).text.length) {
col = 0;
}

Expand All @@ -387,7 +392,7 @@ async function runCppcheckOnFileXML(
continue;
}

const range = new vscode.Range(line, col, line, mainLocDocument.lineAt(line).text.length);
const range = new vscode.Range(line, col, line, mainLocDocument ? mainLocDocument.lineAt(line).text.length : col);
const diagnostic = new vscode.Diagnostic(range, e.$.msg, severity);
diagnostic.source = "cppcheck";
// If we have a link to documentation, include it
Expand All @@ -412,36 +417,55 @@ async function runCppcheckOnFileXML(
continue;
}

const relatedDocument = await vscode.workspace.openTextDocument(loc.file);
var relatedDocument : vscode.TextDocument | undefined;
try {
relatedDocument = await vscode.workspace.openTextDocument(loc.file);
} catch {
// Do nothing
}
const relatedRange = new vscode.Range(
lLine, lCol,
lLine, relatedDocument.lineAt(lLine).text.length
lLine, relatedDocument ? relatedDocument.lineAt(lLine).text.length : lCol
);
relatedInfos.push(
new vscode.DiagnosticRelatedInformation(
new vscode.Location(relatedDocument?.uri ?? '', relatedRange),
new vscode.Location(relatedDocument ? relatedDocument.uri : vscode.Uri.file(''), relatedRange),
msg
)
);
}

if (relatedInfos.length > 0) {
diagnostic.relatedInformation = relatedInfos;
}
const diagnosticFile = mainLoc.file;
if (diagnosticFile === document.fileName) {
var diagnosticFileIsOpenDocument = diagnosticFile === document.fileName;
if (!diagnosticFile.includes('/')) {
// If we do not have file path but only name we asume diagnosed file is open document if they share name
if (document.fileName.endsWith(diagnosticFile)) {
diagnosticFileIsOpenDocument = true;
}
}
if (diagnosticFileIsOpenDocument) {
const uri = document.uri.toString();
if (diagnostics[uri] === null || diagnostics[uri] === undefined) {
diagnostics[uri] = [];
}
diagnostics[uri].push(diagnostic);
} else {
const relatedDocument = await vscode.workspace.openTextDocument(mainLoc.file);
const uri = relatedDocument.uri.toString();
if (diagnostics[uri] === null || diagnostics[uri] === undefined) {
diagnostics[uri] = [];
var relatedDocument : vscode.TextDocument | undefined;
try {
relatedDocument = await vscode.workspace.openTextDocument(mainLoc.file);
} catch {
// Do nothing
}
if (relatedDocument) {
// Proceed if we are able to open the document
const uri = relatedDocument.uri.toString();
if (diagnostics[uri] === null || diagnostics[uri] === undefined) {
diagnostics[uri] = [];
}
diagnostics[uri].push(diagnostic);
}
diagnostics[uri].push(diagnostic);
}
}
const sourceDocumentUri = document.uri.toString();
Expand Down
Loading