-
Notifications
You must be signed in to change notification settings - Fork 3
Ucum normalized #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Ucum normalized #97
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
85e4040
added skip and message to tests with Long in R4 or earlier
bryantaustin13 f300840
adjusted to account for Long in capabilities
bryantaustin13 1f14c3b
adjustments to handle system.long testing
bryantaustin13 9d369e0
file not uploaded as part of fixes
bryantaustin13 bfa4cf9
normalization of ucum to fix compares
bryantaustin13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { BaseExtractor } from '../base-extractor.js'; | ||
|
|
||
| const CQL_TYPE_EXTENSION_URL = 'http://hl7.org/fhir/StructureDefinition/cqf-cqlType'; | ||
|
|
||
| function hasCqlLongType(parameter: any): boolean { | ||
| const extensions = Array.isArray(parameter?.extension) ? parameter.extension : []; | ||
| return extensions.some( | ||
| (extension: any) => | ||
| extension?.url === CQL_TYPE_EXTENSION_URL && | ||
| String(extension?.valueString ?? '').toLowerCase() === 'system.long' | ||
| ); | ||
| } | ||
|
|
||
| function parseLong(value: unknown): bigint | undefined { | ||
| if (value === undefined || value === null) return undefined; | ||
|
|
||
| const text = String(value).trim(); | ||
| const normalized = text.endsWith('L') || text.endsWith('l') ? text.slice(0, -1) : text; | ||
|
|
||
| if (!/^[+-]?\d+$/.test(normalized)) return undefined; | ||
|
|
||
| return BigInt(normalized); | ||
| } | ||
|
|
||
| export class LongExtractor extends BaseExtractor { | ||
| protected _process(parameter: any): any { | ||
| if (parameter.hasOwnProperty('valueInteger64')) { | ||
| return parseLong(parameter.valueInteger64); | ||
| } | ||
|
|
||
| if (parameter.hasOwnProperty('valueString') && hasCqlLongType(parameter)) { | ||
| return parseLong(parameter.valueString); | ||
| } | ||
|
|
||
| return undefined; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The runner shouldn't be casting here, the implementation should be returning the correct type of value, yes?