(WIP) [Interp] Port axi-stream-s2 BNW bug for interpreter, rewrite using repeat loops#188
Draft
ngernest wants to merge 88 commits into
Draft
(WIP) [Interp] Port axi-stream-s2 BNW bug for interpreter, rewrite using repeat loops#188ngernest wants to merge 88 commits into
axi-stream-s2 BNW bug for interpreter, rewrite using repeat loops#188ngernest wants to merge 88 commits into
Conversation
…line numbers instead
…nfcombinatorial explosion
…nferred value != waveform value)
…the current / next cycle) before emitting global monitor failure
…xi-stream-s2-interp
Contributor
Author
|
Edit: the waveforms produced by the BNW test-benches terminate immediately after the bug occurs, so the buggy waveform can't be realized by a monitor failure (since no successful data transfer happens when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to write the protocols for the
axi-stream-s2BNW bug (#158) to userepeatloops in order to express backpressure.Edit: I merged #194 & #197 into this branch so that I could work on it, please review/merge those branches before looking at this PR
TODOs:
.protfiles for the monitor + interpreter (i.e. update the monitor version to refer to the pins in the internal Verilog file instead of the external wrapper module)#[idle]pragma (always printidle()transactions) #189s2_buggy.prot/s2_fixed.protthat usesrepeatloops