Skip to content

SRE-3722 cq: remove chroot-based RPM build pipeline#17944

Open
grom72 wants to merge 9 commits into
masterfrom
grom72/SRE-3722-remove-chroot-rpm-build
Open

SRE-3722 cq: remove chroot-based RPM build pipeline#17944
grom72 wants to merge 9 commits into
masterfrom
grom72/SRE-3722-remove-chroot-rpm-build

Conversation

@grom72
Copy link
Copy Markdown
Contributor

@grom72 grom72 commented Apr 8, 2026

chroot-based RPMs build is no longer supported.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

chroot-based RPMs build is no longer supported.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Skip-python-bandit: true

Skip-unit-tests:true
Skip-unit-test: true
Skip-NLT: true
Skip-unit-test-memcheck: true

Skip-test: true
Skip-func-test: true

Skip-func-vm: true

Skip-func-hw-test: true
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/SRE-3722

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Cancel-prev-build: false

Skip-python-bandit: true

Skip-unit-tests:true
Skip-unit-test: true
Skip-NLT: true
Skip-unit-test-memcheck: true

Allow-unstable-test: true

Skip-test: true
Skip-func-test: true

Skip-func-vm: true

Skip-func-hw-test: true
@daosbuild3
Copy link
Copy Markdown
Collaborator

@daosbuild3
Copy link
Copy Markdown
Collaborator

@daosbuild3
Copy link
Copy Markdown
Collaborator

grom72 added 2 commits April 10, 2026 16:45
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
This reverts commit 2782d1f.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72 grom72 marked this pull request as ready for review April 14, 2026 13:04
@grom72 grom72 requested a review from a team as a code owner April 14, 2026 13:04
@grom72 grom72 requested review from janekmi, jzarzycki and osalyk April 28, 2026 06:22
grom72 added 2 commits April 29, 2026 15:21
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@@ -1,3 +0,0 @@
#!/bin/bash
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this file is still mentioned at least in two places:

  • utils/ansible/ftest/file/daos.spec
  • utils/rpms/daos.spec

, and surprisingly in raft as well:

  • src/rdb/raft/packaging/Makefile_packaging.mk.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you know daos.spec is partially obsolete.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be very old solution (workaround) I will check raft project separately.

Comment thread utils/rpms/packaging/rpm_chrootbuild
Comment thread ci/rpm/build_success.sh
Comment thread ci/rpm/build_success.sh
Comment thread ci/rpm/build_unsuccessful.sh
Comment thread ci/rpm/build.sh Outdated
Comment thread ci/rpm/build.sh Outdated
Comment on lines +21 to +23
scons --jobs "$JOBS" --build-deps=no install PREFIX=/opt/daos COMPILER="$COMPILER" \
FIRMWARE_MGMT=1 BUILD_TYPE="$DAOS_BUILD_TYPE" TARGET_TYPE="$DAOS_TARGET_TYPE" \
USE_INSTALLED=all
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is called ci/rpm/build.sh. Can you actually build RPMs just by calling scons?

Or the name is actually misleading and RPMs were never actually build by this script anyway?

Comment thread ci/rpm/build.sh Outdated
Comment thread ci/rpm/build.sh Outdated
Comment thread ci/rpm/build.sh Outdated
daltonbohning
daltonbohning previously approved these changes May 13, 2026
Copy link
Copy Markdown
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I admit I'm not very familiar to begin with

@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Build on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17944/8/display/redirect

@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Unit Test bdev with memcheck completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17944/8/display/redirect

@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Unit Test with memcheck completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17944/8/display/redirect

@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Unit Test completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17944/8/display/redirect

@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Unit Test bdev completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17944/8/display/redirect

Unify how build arguments are derived in CI and improve the standalone RPM
build script defaults/cleanup for reproducible manual and Jenkins runs.

Use sconsArgs() directly when deciding whether to patch rpmlintrc
Remove redundant SCONS_FAULTS_ARGS environment export
Update Leap 15 build invocation to use sconsArgs() and match other build
stages (stash files, stash_opt, and build_deps=no behavior)
In the RPM build script:
derive JOBS dynamically via nproc
add TARGET and PREFIX defaults
clean stale artifacts before build
run scons with --config=force
tee build output to a target/compiler-specific log file
This reduces duplicated argument plumbing and makes CI/manual builds more
consistent.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
…ove-chroot-rpm-build

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72 grom72 force-pushed the grom72/SRE-3722-remove-chroot-rpm-build branch from 708b55d to f768772 Compare May 28, 2026 18:43
@grom72 grom72 requested a review from janekmi May 28, 2026 18:48
janekmi
janekmi previously approved these changes May 28, 2026
@daosbuild3
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you fix ShellCheck, 👍

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants