Extend retries to 5xx and 408#5364
Open
denik wants to merge 4 commits into
Open
Conversation
Collaborator
|
Commit: 18476af |
Follow up to #5349
…both retried The condition `StatusCode >= 500 && StatusCode == 408` is logically impossible (no code can satisfy both). Using `||` lets both 5xx errors and 408 Request Timeout trigger the retry path, which is the intended behaviour from the parent commit. Co-authored-by: Isaac
pietern
approved these changes
Jun 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #5349
Analysis shows 500 and 408 errors show up as well (although what we saw is those errors happen during file upload, but no reason it cannot happen on other endpoints).