docs schema: drop jsonschema_for_docs.json from main, keep on docgen#5388
Draft
shreyas-goenka wants to merge 1 commit into
Draft
docs schema: drop jsonschema_for_docs.json from main, keep on docgen#5388shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
shreyas-goenka
changed the title
The docs schema (`bundle/schema/jsonschema_for_docs.json`) is consumed only by the DABs docs tooling, which now reads it from the `docgen` branch. There is no reason to carry the generated file on `main` or to regenerate it during the normal local codegen flow: - Delete the committed `bundle/schema/jsonschema_for_docs.json` from `main`. - Drop `generate-schema-docs` from the `generate` and `all` aggregators so `./task generate` no longer produces it. The task definition stays — the update-schema-docs release workflow still invokes it directly — and gains a note warning against re-adding it to an aggregator. - update-schema-docs.yml: regeneration now creates the file as an untracked artifact (it is no longer tracked on `main`), so the post-regen assertion checks for `?? ...` instead of ` M ...`, and an empty status is now an error. - Remove the now-stale references to the file from `.wsignore`, `bundle/schema/.gitattributes`, and `.agent/rules/auto-generated-files.md`. `bundle/schema/jsonschema.json` (the canonical schema, embedded in the binary and used by Python codegen) is unaffected. Co-authored-by: Isaac
shreyas-goenka
force-pushed
the
shreyas-goenka/docs-schema-docgen-only
branch
from
5c4276b to
c2349bd
Compare
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
bundle/schema/jsonschema_for_docs.jsonoffmain— it's now read from thedocgenbranch (published byupdate-schema-docs.ymlper release). Generation stays scoped to that release workflow.main.generate-schema-docsfrom thegenerate/allaggregators; keep the task def (the release workflow invokes it).update-schema-docs.yml: regen now yields an untracked file, so the assertion checks??notM..wsignore,.gitattributes,.agent/rules/auto-generated-files.md.jsonschema.json(embedded, used by codegen) is untouched.This pull request and its description were written by Isaac.