bundle/deploy/lock: wire DMS into NewDeploymentLock via experimental.use_managed_state#5395
Draft
shreyas-goenka wants to merge 1 commit into
Conversation
…use_managed_state When experimental.use_managed_state is set in databricks.yml, NewDeploymentLock now creates a metadataServiceLock alongside the workspace-filesystem lock. Acquire calls DMS CreateVersion after acquiring the file lock; Release calls DMS CompleteVersion before releasing it. Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 35de00c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the DMS
metadataServiceLock(added in #5386) intoNewDeploymentLockbehind theexperimental.use_managed_stateconfig field. When the field is set, each deploy/destroy registers a versioned record with the Deployment Metadata Service alongside the workspace-filesystem lock.What changed
bundle/config/experimental.go— addsUseManagedState boolfield toExperimental:bundle/deploy/lock/lock.go—NewDeploymentLockchecksb.Config.Experimental.UseManagedState; when true, creates ametadataServiceLockand assigns it tol.dms.Acquire/Releasealready call the DMS helper whenl.dms != nil(from #5386).Behavior when enabled
Acquire: acquires the workspace-filesystem lock, then callssvc.CreateVersionto claim a server-side deployment versionRelease: callssvc.CompleteVersion(with success/failure), then releases the file lock; onGoalDestroy+success, also callssvc.DeleteDeploymentmanaged_service.jsonin the workspace state directoryTest plan
go build ./...cleango test ./bundle/...green