Skip to content

test: fix flaky DSDynamicTypeBindRelationService spec (double spyOn) #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanmajchrak merged 3 commits into from
Jul 1, 2026
+14 −11
Merged

test: fix flaky DSDynamicTypeBindRelationService spec (double spyOn) #1338

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b924ae5
test: fix flaky DSDynamicTypeBindRelationService spec (double spyOn)
milanmajchrak Jul 1, 2026
1a31754
test: await TestBed setup in DSDynamicTypeBindRelationService spec
milanmajchrak Jul 1, 2026
4a392fd
test: reword beforeEach comment (address Copilot review)
milanmajchrak Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions src/app/shared/form/builder/ds-dynamic-form-ui/ds-dynamic-type-bind-relation.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,18 @@ describe('DSDynamicTypeBindRelationService test suite', () => {
let injector: Injector;

beforeEach(() => {
TestBed.configureTestingModule({
// Return the promise so the module (and its fresh getMockFormBuilderService() spy mock) is fully set up
// before each spec runs; the previous dangling .then() did not await, letting asynchronous module setup
// leak between specs.
return TestBed.configureTestingModule({
imports: [ReactiveFormsModule],
providers: [
{ provide: FormBuilderService, useValue: getMockFormBuilderService() },
{ provide: DsDynamicTypeBindRelationService, useClass: DsDynamicTypeBindRelationService },
{ provide: DynamicFormRelationService },
DISABLED_MATCHER_PROVIDER, HIDDEN_MATCHER_PROVIDER, REQUIRED_MATCHER_PROVIDER
]
}).compileComponents().then();
}).compileComponents();
});

beforeEach(inject([DsDynamicTypeBindRelationService, DynamicFormRelationService],
Expand Down Expand Up @@ -86,7 +89,7 @@ describe('DSDynamicTypeBindRelationService test suite', () => {
it('Should not push undefined bind models', () => {
const testModel = mockInputWithTypeBindModel;
testModel.typeBindRelations = getTypeBindRelations(['boundType']);
spyOn((service as any).formBuilderService, 'getTypeBindModel').and.returnValue(undefined);
((service as any).formBuilderService.getTypeBindModel as jasmine.Spy).and.returnValue(undefined);

const relatedModels = service.getRelatedFormModel(testModel);

Expand Down Expand Up @@ -143,7 +146,7 @@ describe('DSDynamicTypeBindRelationService test suite', () => {
opposingMatch: HIDDEN_MATCHER.match,
onChange: jasmine.createSpy('onChange')
};
spyOn((service as any).formBuilderService, 'getTypeBindModel').and.returnValue(undefined);
((service as any).formBuilderService.getTypeBindModel as jasmine.Spy).and.returnValue(undefined);

const hasMatch = service.matchesCondition(relation, visibleMatcher);

Expand All @@ -159,7 +162,7 @@ describe('DSDynamicTypeBindRelationService test suite', () => {
opposingMatch: MATCH_VISIBLE,
onChange: jasmine.createSpy('onChange')
};
spyOn((service as any).formBuilderService, 'getTypeBindModel').and.returnValue(undefined);
((service as any).formBuilderService.getTypeBindModel as jasmine.Spy).and.returnValue(undefined);

const hasMatch = service.matchesCondition(relation, hiddenMatcher);

Expand All @@ -185,8 +188,8 @@ describe('DSDynamicTypeBindRelationService test suite', () => {
onChange: jasmine.createSpy('onChange')
};
(service as any).dynamicMatchers = [visibleMatcher];
spyOn((service as any).formBuilderService, 'getTypeBindModel').and.callFake(() => bindModelAvailable ? bindModel : undefined);
spyOn((service as any).formBuilderService, 'getTypeBindModelUpdates').and.returnValue(bindModelUpdates$.asObservable());
((service as any).formBuilderService.getTypeBindModel as jasmine.Spy).and.callFake(() => bindModelAvailable ? bindModel : undefined);
((service as any).formBuilderService.getTypeBindModelUpdates as jasmine.Spy).and.returnValue(bindModelUpdates$.asObservable());

const subscriptions = service.subscribeRelations(testModel, dcTypeControl);
expect(subscriptions.length).toBe(1);
Expand Down Expand Up @@ -220,8 +223,8 @@ describe('DSDynamicTypeBindRelationService test suite', () => {
onChange: jasmine.createSpy('onChange')
};
(service as any).dynamicMatchers = [hiddenMatcher];
spyOn((service as any).formBuilderService, 'getTypeBindModel').and.callFake(() => bindModelAvailable ? bindModel : undefined);
spyOn((service as any).formBuilderService, 'getTypeBindModelUpdates').and.returnValue(bindModelUpdates$.asObservable());
((service as any).formBuilderService.getTypeBindModel as jasmine.Spy).and.callFake(() => bindModelAvailable ? bindModel : undefined);
((service as any).formBuilderService.getTypeBindModelUpdates as jasmine.Spy).and.returnValue(bindModelUpdates$.asObservable());

const subscriptions = service.subscribeRelations(testModel, dcTypeControl);
expect(subscriptions.length).toBe(1);
Expand Down Expand Up @@ -254,8 +257,8 @@ describe('DSDynamicTypeBindRelationService test suite', () => {
onChange: jasmine.createSpy('onChange')
};
(service as any).dynamicMatchers = [visibleMatcher];
spyOn((service as any).formBuilderService, 'getTypeBindModel').and.callFake(() => bindModelAvailable ? bindModel : undefined);
spyOn((service as any).formBuilderService, 'getTypeBindModelUpdates').and.returnValue(bindModelUpdates$.asObservable());
((service as any).formBuilderService.getTypeBindModel as jasmine.Spy).and.callFake(() => bindModelAvailable ? bindModel : undefined);
((service as any).formBuilderService.getTypeBindModelUpdates as jasmine.Spy).and.returnValue(bindModelUpdates$.asObservable());

const subscriptions = service.subscribeRelations(testModel, dcTypeControl);
expect(visibleMatcher.onChange).toHaveBeenCalledWith(false, testModel, dcTypeControl, jasmine.anything());
Expand Down
Loading