[dmt] add module-package-consistency rule with --fix support

[diyliv]

Summary

• Cross-validation rule (module_package_consistency.go): compares overlapping fields (name, requirements.deckhouse, requirements.kubernetes, requirements.modules) between module.yaml and package.yaml when both files exist, reporting any divergence. package.yaml is treated as source of truth.
• --fix mode (module_package_fix.go): AST-based YAML patching rewrites module.yaml fields to match package.yaml values. Preserves comments, field ordering, and untouched fields. Atomic write via temp file + rename. Maps package.yaml mandatory/conditional module groups to old-spec flat map format (!optional suffix).
• Unmapped fields warning (lint_errors.go:ReportUnmappedFields): emits warnings for anyOf and subscribe sections in package.yaml that have no representation in module.yaml.
• Flag wiring: adds --fix boolean flag to dmt lint command (flags.go).
• Config wiring: consistency rule already had ModulePackageConsistencyRule config field; module.go now passes flags.Fix to the rule check.
• Tests: 34 test cases covering name/deckhouse/kubernetes mismatch, module mandatory↔conditional cross-check, constraint mismatch, partial presence (only one file, empty fields), anyOf handling, fix mode for all field types, comment/ordering preservation in fix, and integration test matching user-provided example with non-standard required key and prefix !optional format.

Context

When both module.yaml and package.yaml exist in a module directory, their overlapping fields (name, deckhouse/kubernetes constraints, module dependencies) can diverge over time. This rule detects inconsistencies and --fix automatically patches module.yaml to match package.yaml (old spec format), treating package.yaml as the authoritative source.

Example

Module with diverging module.yaml and package.yaml:

module.yaml (before fix):

name: wrong-name
requirements:
  deckhouse: ">=0.0.0"
  kubernetes: ">=1.19.0"
  modules:
    required:
      prompp: "!optional >=0.16.0"

package.yaml (source of truth):

name: correct-name
requirements:
  deckhouse:
    constraint: ">=0.1.0"
  kubernetes:
    constraint: ">=1.20.0"
  modules:
    mandatory:
      - name: stronghold
        constraint: ">=0.1.0"
    conditional:
      - name: prompp
        constraint: ">=0.1.0"
    anyOf:
      - description: "cloud provider"
        modules:
          - name: cloud-provider-aws
            constraint: ">=1.0.0"

Before: dmt lint reports 6 errors (name, deckhouse, kubernetes, missing stronghold, wrong prompp constraint, extra missing-mod).

After dmt lint --fix:

• All 6 errors resolved, module.yaml rewritten to:

name: correct-name
requirements:
  deckhouse: ">=0.1.0"
  kubernetes: ">=1.20.0"
  modules:
    stronghold: '>=0.1.0'
    prompp: '>=0.1.0 !optional'

• Warning emitted: package.yaml has anyOf modules which cannot be represented in module.yaml

[Copilot]

Pull request overview

Adds a new module-package-consistency cross-validation capability with an optional --fix mode that rewrites module.yaml fields to match package.yaml (as the source of truth), plus CLI wiring and expanded test coverage.

Changes:

• Introduce AST-based YAML patcher to auto-fix module.yaml (name, requirements.deckhouse/kubernetes, requirements.modules) from package.yaml.
• Extend the consistency rule to optionally run the fixer and emit warnings for package.yaml sections that can’t be represented in module.yaml (anyOf, subscribe).
• Wire --fix flag into dmt lint and add fix-mode tests.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pkg/linters/module/rules/module_package_fix.go	New YAML AST patching implementation for module.yaml rewrite.
pkg/linters/module/rules/module_package_consistency.go	Adds --fix integration via FixFn and fix/warn flow before comparisons.
pkg/linters/module/rules/module_package_consistency_test.go	Adds fix-mode tests validating rewrite behavior and warnings.
pkg/linters/module/module.go	Wires CLI flags.Fix into the consistency rule invocation.
internal/flags/flags.go	Adds dmt lint --fix boolean flag.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

[diyliv]

fixed