Skip to content

test: migrate VirtualMachineImageHotplug e2e test to new framework #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eofff wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test: migrate VirtualMachineImageHotplug e2e test to new framework #2443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1f5fad
rewrite
Jun 4, 2026
fcd4aa8
fix linter
Jun 4, 2026
5c453d6
resolve
Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .dmtlint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ linters-settings:
directories:
- tools/addlicense/testdata
- test/performance/ssh
- test/e2e/legacy/testdata/sshkeys
- images/dvcr-artifact/staging
container:
exclude-rules:
Expand Down
3 changes: 0 additions & 3 deletions .gitleaks.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,12 @@ commits = [
"7779a9548280e3d28cd44555efe6d0e18a106b09",
# images/virtualization-artifact/config/vm_sysprep.yaml - example config
"552a06eb1d2f50ca2d765d42c5ab4d701c92a555",
# legacy entry
"d964aca8c51cc3f2dcd0d72b6016fa6ad94c1ce4",
]
paths = [
# test files and data
'''^images/dvcr-artifact/pkg/uploader/testdata/auth.json$''',
'''^images/hooks/pkg/hooks/generate-secret-for-dvcr/hook_test.go$''',
'''^images/hooks/cmd/generate-secret-for-dvcr/main_test\.go$''',
'''^test/e2e/legacy/testdata/sshkeys/id_ed$''',
'''^test/e2e/internal/object/const.go$''',
'''^tests/e2e/object/const\.go$''',
'''^tests/e2e/testdata/connectivity/sshkeys/id_ed$''',
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ task runp
- Use the FOCUS environment variable to run a specific test.
- Set `POST_CLEANUP=never` to disable cleanup after tests (takes precedence over `postCleanupMode` in config).
- Set LABELS to run tests with specific label(https://onsi.github.io/ginkgo/#spec-labels).
- Manage timeouts for new e2e tests (not for legacy tests) using env variables `E2E_SHORT_TIMEOUT`, `E2E_MIDDLE_TIMEOUT`, `E2E_LONG_TIMEOUT` and `E2E_MAX_TIMEOUT`.
- Manage timeouts for e2e tests using env variables `E2E_SHORT_TIMEOUT`, `E2E_MIDDLE_TIMEOUT`, `E2E_LONG_TIMEOUT` and `E2E_MAX_TIMEOUT`.

For example, to run only one test and leave all created resources in the cluster, use the following command:
```bash
Expand Down
13 changes: 0 additions & 13 deletions test/e2e/Taskfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,6 @@ vars:
VERSION: "v1.0.0"

tasks:
copy:
cmds:
- |
if [ "{{OS}}" == "darwin" ]; then
rm -rf /tmp/testdata
else
rm --force --recursive /tmp/testdata
fi
cp -a legacy/testdata /tmp/testdata

kubectl:
cmds:
- |
Expand All @@ -35,7 +25,6 @@ tasks:
run:ci:
desc: "Run e2e tests in GitHub Actions"
deps:
- copy
- kubectl
- d8
cmds:
Expand All @@ -52,7 +41,6 @@ tasks:
run:
desc: "Run e2e tests"
deps:
- copy
- kubectl
- d8
- precheck:prepare
Expand Down Expand Up @@ -84,7 +72,6 @@ tasks:
runp:
desc: "Run e2e tests in parallel mode"
deps:
- copy
- kubectl
- d8
- precheck:prepare
Expand Down
Loading
Loading