fix(vm): fix rootless upgrade migration for VMs with container disks#2478
Open
loktev-d wants to merge 4 commits into
Open
fix(vm): fix rootless upgrade migration for VMs with container disks#2478loktev-d wants to merge 4 commits into
loktev-d wants to merge 4 commits into
Conversation
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
Contributor
|
Workflow has started. The target step completed with status: failure. |
Contributor
|
Workflow has started. The target step completed with status: failure. |
Signed-off-by: Daniil Loktev <70405899+loktev-d@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes live migration of container-disk VMs in kubevirt:
unknown user deckhouse: a 1.9 virt-handler probing a 1.8 launcher's container disk viavirt-chroot --user deckhousefails (the old launcher image has nodeckhouseuser), so the source VMI never syncs.GetImageInfonow falls back to the legacyqemuuser when the launcher predatesdeckhouse(pkg/virt-handler/container-disk/hotplug.go).Hotplug container disk not mounted on the migration target:findVirtlauncherUIDmatched the target launcher by its hotplug-disks dir, but a terminated pod left inActivePodskeeps that dir, so a lingering pod yields multiple matches and skips the bind-mount. It now keys off the launcher command socket (live pod only).cmd.StderrPipe()+cmd.Output().Wait()closed the pipe before stderr was read, so every failure logged with no reason. Switched to a capturedbytes.Buffer.Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries