Feature branch sync - pub/q2_upgrade to staging#4750
Merged
Conversation
Signed-off-by: pullan1 <sudha.pullalaravu@dell.com>
Signed-off-by: pullan1 <sudha.pullalaravu@dell.com>
Signed-off-by: pullan1 <sudha.pullalaravu@dell.com>
Signed-off-by: pullan1 <sudha.pullalaravu@dell.com>
Signed-off-by: Abhishek S A <abhishek.sa3@dell.com>
Signed-off-by: pullan1 <sudha.pullalaravu@dell.com>
checkmarx fix
Signed-off-by: pullan1 <sudha.pullalaravu@dell.com>
Checkmarx fix localrepo
Signed-off-by: Abhishek S A <abhishek.sa3@dell.com>
Signed-off-by: Abhishek S A <abhishek.sa3@dell.com>
Fix: Separate input validation flow for build and deploy
Add input validation to ensure ADMIN_IP addresses in the PXE mapping file (pxe_mapping_file.csv) belong to a subnet defined in network_spec.yml — either the primary admin_network or one of the additional_subnets. Previously this check only ran during HA validation. Now it runs for all deployments in validate_provision_config, catching Scenario 1 of the multi-subnet DHCP defect where ADMIN_IPs from undefined subnets passed validation silently. Changes: - Extract validate_pxe_admin_ips_subnet_consistency() as a standalone testable function in provision_validation.py - Import is_ip_in_subnet directly; no cross-dependency on HA-specific vip_pxe_validation module - Guard against yaml.safe_load returning None for empty network_spec - Produce clear error messages referencing primary admin subnet and additional_subnets (no misleading VIP references) - Add 6 unit tests exercising the production code path directly Signed-off-by: Sujit Jadhav <sujit.jadhav@dell.com>
Signed-off-by: Abhishek S A <abhishek.sa3@dell.com>
Signed-off-by: Abhishek S A <abhishek.sa3@dell.com>
… victoria-pump deployment (#4742) * input_validation changes for the powerscale telemetry * Update en_us_validation_msg.py Signed-off-by: balajikumaran.cs <balajikumaran.cs@dellteam.com> * Update en_us_validation_msg.py Signed-off-by: balajikumaran.cs <balajikumaran.cs@dellteam.com> * Update en_us_validation_msg.py Signed-off-by: balajikumaran.cs <balajikumaran.cs@dellteam.com> * s3_cmd and victoria_metrics changes * Update cleanup_openchami.yml Signed-off-by: balajikumaran.cs <balajikumaran.cs@dellteam.com> * lint fix * Update cleanup_openchami.yml Signed-off-by: balajikumaran.cs <balajikumaran.cs@dellteam.com> --------- Signed-off-by: balajikumaran.cs <balajikumaran.cs@dellteam.com>
update powerscale telemetry packages
pub/q2_upgrade sync
Signed-off-by: Abhishek S A <abhishek.sa3@dell.com>
aarch64 image builder update to fix vulnerbility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature branch sync - pub/q2_upgrade to staging