AMP-31085 : Remove risk and logframe#4503
Open
brianbrix wants to merge 7 commits into
Open
Conversation
brianbrix
force-pushed
the
fix/AMP-31133/Risk-and-logframe-fields
branch
from
3d1334e to
063a9d1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates AMP’s activity interchange/export behavior and possible-values enumeration to better handle indicator/category-related data, alongside a frontend dependency bump.
Changes:
- Update
amp-uidependency commit reference in the templatepackage-lock.json. - Add a fallback path when a category field is missing a discriminator, returning generic category values (with a warning).
- Extend activity JSON export enrichment to include non-disaggregated indicator values (
base,target,revised) in addition to existing indicator augmentations.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| amp/TEMPLATE/reamp/package-lock.json | Bumps amp-ui git commit reference in the template lockfile. |
| amp/src/main/java/org/digijava/kernel/ampapi/endpoints/activity/PossibleValuesEnumerator.java | Adds a warning + fallback to generic category value enumeration when discriminator is missing. |
| amp/src/main/java/org/digijava/kernel/ampapi/endpoints/activity/ActivityInterchangeUtils.java | Adds enrichment of exported indicators with base/target/revised values and a small serializer helper. |
Files not reviewed (1)
- amp/TEMPLATE/reamp/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+332
to
+334
| Long activityLocationId = parseLong(indicator.get("activity_location")); | ||
| AmpActivityLocation activityLocation = getActivityLocation(projectId, activityLocationId); | ||
| boolean singleLocationFallback = activityLocationId == null && activityLocation != null; |
brianbrix
force-pushed
the
fix/AMP-31133/Risk-and-logframe-fields
branch
from
7be472c to
e018434
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.