#1928: Added Upgrade IDEasy and Update functionalities to the GUI with pro active notifications#2027
Open
KarimALotfy wants to merge 70 commits into
Conversation
- Added testing class for modals
- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.
- Added testing class for modals
- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.
…t-for-gui' into devonfw#1785-implement-modals-in-idecontext
- Added functionality, that selecting a different project now switches the IdeContext to the new project.
…plementation' into devonfw#1802-state-management-implementation
…r other ui feature branches
- added DI for IdeGuiStateManager.switchContext
…reading the list of workspaces/projects instead of reading those from the UI
…nager, when switchContext(Path rootDirectory, ...) is called.
This reverts commit 6f92d93.
…plementation' into devonfw#1802-state-management-implementation
…tateManager is now set when calling getInstance(), allowing us to provide a getInstance() method with a DI parameter
… getInstance()) (see previous commit)
…can be extended by tests
…plementation' into devonfw#1802-state-management-implementation
- Updated the main UI section - Created tests covering: update available / unavailable upgrade available / unavailable Consolidated shared test setup for the GUI flows
…h an indicator and a dialog, replacing the update card
KarimALotfy
added
GUI
Collaborator
Coverage Report for CI Build 29614403988Coverage decreased (-0.3%) to 72.087%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions55 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
…how-pro-active-notifications-of-updates-in-gui"
7 tasks
…ligning with the updates of the newly modified NlsService
…ce classes, and refactoring
JoelAdbu
reviewed
Jul 17, 2026
| * @return true if an upgrade is available, false otherwise | ||
| */ | ||
| public boolean checkForUpgrade() { | ||
|
|
Contributor
There was a problem hiding this comment.
While testing a local development build (IdeVersion.isUndefined() / "SNAPSHOT"), I noticed that the upgrade indicator is shown permanently.
The upgrade dialog displays:
Version "SNAPSHOT" needs to be updated to "SNAPSHOT"Clicking Upgrade triggers the upgrade flow, but the backend skips the installation because local development versions are not upgradeable. After completion, the indicator immediately appears again, resulting in an endless upgrade loop.
One possible solution could be to skip upgrade checks entirely for undefined development versions:
Suggested change
| if (IdeVersion.isUndefined()) { | |
| return false; | |
| } | |
This would be consistent with the existing IdeasyCommandlet.doInstall(..) behavior, which already skips upgrades for undefined development versions.
steps for reproduction:
- delete/comment TestGuiConfiguration.applyConfigOverrides(); in App.java
- Start a local SNAPSHOT build.
- Start Gui
- Open the upgrade dialog.
- Click Upgrade.
- Observe that the upgrade is skipped and immediately offered again.
JoelAdbu
reviewed
Jul 17, 2026
Comment on lines
+64
to
+65
| @FXML | ||
| private Button upgradeButton; |
Contributor
There was a problem hiding this comment.
Maybe better renaming this to updateButton?
Contributor
|
Tested the manual upgrade and update flows according to the provided testing instructions.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1928
Implemented Changes
Created UpgradeController
Created UpdateController
ComboBox, opening a dialog that allows running the update command.Controller / architecture adjustments
MainControllerto allow dependency injection.Localization
#1936.messages.propertiesandmessages_de.properties.Tests
UpgradeUpdateFlowTestas end-to-end GUI integration tests for both update and upgrade flows using the new indicator + dialog pattern.UI refactoring
main-view.fxmlso the tool cards are displayed in a grid layout, aligned with the Figma design:Tray notification service
TrayNotificationServiceto avoid duplicated tray-indicator logic.UpgradeControllerandUpdateControllerto show the clickable tray indicator when an upgrade or update is available.Testing Instructions
1. GUI testing with overridden configuration
A test configuration class was added:
TestGuiConfigurationThis allows overriding the current IDEasy version and update availability via environment variables when launching the GUI.
Example:
IDE_VERSION=2026.02.001;IDE_UPDATE_AVAILABLE=trueUsage:
Upgrade flow
Update flow
ComboBox.2. Run automated tests
Run the following test class:
UpgradeUpdateFlowTestThis validates both update and upgrade flows
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal