#2039: Added workaround for app icon in MacOS Dock#2161
Open
oanding-blrng wants to merge 4 commits into
Open
Conversation
…anually on macOS systems.
… macOS by adding a check and method in App.java
…ac-task-bar' into fix/2039-IDE-logo-not-shown-in-mac-task-bar
…added ticket to CHANGELOG.adoc.
Collaborator
Coverage Report for CI Build 29334321101Warning No base build found for commit Coverage: 72.181%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
Contributor
Author
|
As of time of writing two tests regarding the localization are failing: All other tests are running successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes: #2039
Implemented changes:
App.javato set icon in taskbar/dock in macOS with workaround and condition to only call new method, if we are on a macOS systemTesting instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
gui/src/main/resources/com/devonfw/ide/gui/assets/devonfw.pngwill be used as the icon in the taskbar/dockChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal