Add movies and TV show search bar to app shell#94
Closed
CyberoniOntoni wants to merge 7 commits into
Closed
Conversation
Centralize gamepad virtual-key handling in GamepadInput and route shell navigation (menu toggle, left-edge open, B/Escape back) through NavigationManager at the CoreWindow level so it works on every content page, not only when MainPage has focus. Video playback now maps A to play/pause, X to mute, and D-pad/stick directions to volume and seeking. Login and server selection accept Gamepad A to submit. WebVideo supports B to go back.
Place a styled AutoSuggestBox at the top of MainPage with debounced Jellyfin search hints. Submitting a query or picking a suggestion navigates to search results or item details. Includes a dedicated Search page with portrait result cards and adjusted content page spacing for the new header.
Replace nested TwoWay x:Bind on search text with code-behind TextChanged handling, use ObservableCollection for suggestions with TextMemberPath, simplify the search box style, and restore full-screen navigation overlay span.
Suppress duplicate QuerySubmitted navigation after SuggestionChosen, cancel stale ItemDetails loads when navigating away, and guard against null UserData on series items.
Defer AutoSuggestBox suggestion navigation to the next UI frame, reset ItemDetails playback state between loads, use null-safe stream bindings, navigate cards by item id, and log unhandled exceptions to the debug output.
AutoSuggestBox TextMemberPath requires WinRT bindable custom properties on suggestion items. Selection text is already applied in code when a suggestion is chosen.
This was referenced Jun 20, 2026
Reload search results when submitting the same query on the results page. Collapse suggestion picking into ShellSearchViewModel.SelectSuggestion with debounce suppression. Add stale-load guards to SearchViewModel. Restore PR dfederm#93 NavigationManager menu and gamepad polish (OpenNavigationMenu only, GamepadA focus fix, unified text-input checks).
Owner
|
@CyberoniOntoni I noticed you closed this and your other PRs. Are you just reorganizing/rebasing the PRs or abandoning the work? The changes do look useful and like something I'd want to integrate in, so I'm hoping it's the former and not the latter. Thanks! |
Contributor
Author
@dfederm Hi! Yes, I want to reorganize them a little bit. There was quite a bit of overlap here and there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a persistent movies/TV search bar to the app shell, plus stability fixes for AutoSuggestBox and search-to-details navigation.
Search
AutoSuggestBoxinMainPagewith debounced Jellyfin search hintsSearchresults page with portrait cardsCrash fixes
x:Bindon search text with code-behind handlingTextMemberPath(requires WinRT-bindable custom properties)SuggestionChosenItemDetailsloads; guard nullUserDataon series itemsMerge order
Replaces the search portion of closed #89.
Test plan