Fix Xbox shell focus, search, and library filter navigation#98
Merged
Merged
Conversation
This was referenced Jun 20, 2026
ad47b6c to
c1f7bd0
Compare
c1f7bd0 to
5a9c293
Compare
54e2f39 to
9d055d4
Compare
Contributor
Author
|
There's going to be a follow-up PR after #101 (which fixes search panel behavior), with a bugfix for a seek bar (control bar) not autohiding during playback. |
dfederm
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased onto current
main(single commit, 29 files, +936/−76). Builds on merged #93 (controller shell), #97 (packaging), and #100 (CancellableLoad).Adds a persistent shell search bar with suggestions and a full Search results page, fixes Xbox focus crashes and library filter controller navigation, and hardens item-details loading.
Shell search
AutoSuggestBoxinMainPagewith debounced suggestions (ShellSearchViewModel)Searchpage for full query results (SearchViewModel)SelectSuggestionconsolidates suggestion pick (cancel in-flight fetch, clear field, navigate)NavigateToSearchreloads results when already on Search with the same querySearch.OnNavigatingFromcancels in-flight loadsNavigationManager.NavigateToItemAsync)CollectionNavigationroutes collection folders to library views (single type→kind/title mapping)Xbox focus fixes
MainPagetogglesIsTabStopinstead of invalidFocusState.Unfocused(fixes Xbox0xc000027bcrash)TrySetNewFocusedElement(SectionNavigationBehavior+TrapAtTop)XYFocusRightmoved to code-behind (dynamic focus chain when filters are active)Load cancellation (#100 integration)
ItemDetailsViewModelandSearchViewModeluseCancellableLoad(not manual version counters)CancellableLoad.CancelAsync()added forItemDetails.OnNavigatingFromItemDetailsViewModelresets display state on reload; null-safe media-source bindingsTest plan
0xc000027b)