chore(vetkeys): migrate password_manager to icp-cli and @icp-sdk/vetkeys#1351
Open
marc0olo wants to merge 23 commits into
Open
chore(vetkeys): migrate password_manager to icp-cli and @icp-sdk/vetkeys#1351marc0olo wants to merge 23 commits into
marc0olo wants to merge 23 commits into
Conversation
- Replace dfx.json with icp.yaml (Rust and Motoko backends) - Update existing motoko/backend/icp.yaml (remove --enhanced-orthogonal-persistence) - Use @icp-sdk/vetkeys@0.5.0-beta.0 instead of @dfinity/vetkeys - Use @icp-sdk/auth@7.1.0 and @icp-sdk/core@5.4.0 - Update Motoko ic-vetkeys to 0.5.0, Rust ic-vetkeys to 0.7.0 - Add moc 1.5.1 toolchain to mops.toml - Rename tailwind.config.cjs to tailwind.config.mjs - Add CI workflow for both Rust and Motoko backends - Drop icp.ninja support Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
….1.0 API - Remove rust-toolchain channel pin and profile - Bump ic-cdk to 0.20.1 and add ic-cdk-management-canister 0.1.1 - Update ic_cdk::management_canister imports to ic_cdk_management_canister - Update AuthClient: constructor, signIn/signOut, async getIdentity Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The motoko/backend/icp.yaml runs from motoko/backend/ but referenced 'frontend' directly. The shared frontend is at ../../frontend relative to that location. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…refix Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Change test_key_1 → key_1 in all icp.yaml: icp-cli 0.2.7 only provisions vetkd:Bls12_381_G2:key_1 (TestThresholdKeys subnet with test_key_1 is not yet supported by icp-cli). The vetkeys library itself uses key_1 in its own icp.yaml files. - Add --yes flag to npx @icp-sdk/bindgen to suppress the install confirmation prompt during local builds - basic_ibe: wrap event listeners in try-catch so errors are caught and shown (not silent unhandled rejections); add console.error() alongside alert() so errors are visible and copyable in DevTools Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…vetkeys Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add Folder Structure section explaining rust/, motoko/, frontend/ layout and why backends are in subdirectories (shared frontend via symlinks) - Replace vague "from the X folder" wording with explicit `cd X` commands - Fix `npm run dev` → `npm run dev:rust` / `npm run dev:motoko` (bare `dev` script intentionally errors with a "specify a backend" message) - Add `cd frontend` before all dev commands (package.json is in frontend/, not at the example root) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…d.ai - rootKey: pass rootKey: canisterEnv?.IC_ROOT_KEY directly; undefined is fine when on mainnet (HttpAgent ignores it) - identityProvider local: use /authorize path instead of /#authorize hash - identityProvider production: use https://id.ai instead of undefined Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…work-launcher) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace provision scripts + macOS + Linux dual-platform setup with single Ubuntu job using icp-dev-env Docker images: - ghcr.io/dfinity/icp-dev-env-rust:0.1.0 for Rust backends - ghcr.io/dfinity/icp-dev-env-motoko:0.1.0 for Motoko backends Eliminates: provision-darwin/linux.sh, pre-download-launcher.sh, actions/setup-node, cargo install candid-extractor, ICP_CLI_GITHUB_TOKEN, and macOS runners. Consistent with hello_world and who_am_i examples. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Follows hello_world/who_am_i naming (no language prefix, no -example suffix), keeping vetkeys- namespace prefix for grouping. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Workflow name: vetkeys-{example} (no rust- prefix)
Job IDs: rust and motoko (example name not needed in job context)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The icp-dev-env container downloads the network launcher from GitHub on first run. Without authentication this hits the 60 req/hr unauthenticated API limit. Pass GITHUB_TOKEN so downloads use the authenticated 5000 req/hr limit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ndition Workaround for dfinity/icp-js-auth#120 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…alls getIdentity() is async in @icp-sdk/auth@7.1.0. Store the principal in the auth state at authentication time and use $auth.principal in all components instead of calling getIdentity().getPrincipal() directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ENCRYPTED_MAPS is a heap thread_local that resets to None after a canister upgrade (init is not called on upgrade, only post_upgrade). Store the key_name in a StableCell (persists across upgrades) and add a post_upgrade hook that reinitializes ENCRYPTED_MAPS from it — same pattern used in basic_ibe and basic_timelock_ibe backends. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tures 0.6.8 StableCell::init() and set() in ic-stable-structures 0.6.8 return values directly, not Result — .expect() does not apply. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…e mops.toml - Move icp.yaml from motoko/backend/ to motoko/ (consistent with all other examples where icp deploy runs from the language root folder) - Update main: path to backend/src/Main.mo - Update frontend build path from ../../frontend to frontend (symlink) - Remove motoko/backend/mops.toml (redundant — motoko/mops.toml is used) - Update CI workflow working-directory: motoko/backend → motoko - Update README deploy instructions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Rename domain separator strings and disclaimer text. Requires --mode reinstall on next deploy (changing domain separator changes key derivation, so old encrypted data would be inaccessible anyway). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the
password_managervetkeys example as part of #1343:dfx.jsonwithicp.yamlfor Rust backend; updates existingmotoko/backend/icp.yaml(removes--enhanced-orthogonal-persistence)@dfinity/vetkeys@0.3.0with@icp-sdk/vetkeys@0.5.0-beta.0@dfinity/*packages with@icp-sdk/auth@7.1.0/@icp-sdk/core@5.4.0ic-vetkeysto0.7.0, Motokoic-vetkeysto0.5.0moc = "1.9.0"and migrates frombasetocore = "2.5.0"; upgradesic-vetkeysfrom0.4.0to0.5.0inmotoko/backend/mops.tomltailwind.config.cjs→tailwind.config.mjs(required by"type": "module")vite.config.tsto useicpCLI for dev server configdev:rust/dev:motokonpm scriptsvetkeys-{example}.ymlworkflow naming (consistent withhello_world.yml/who_am_i.ymlconvention); jobs named{language}-{example}vetkeys-{example}.yml) using icp-dev-env container images on UbuntuTest plan
npm installresolves without errors infrontend/icp network start -d && icp deploysucceeds fromrust/andmotoko/backend/dirs@dfinity/vetkeysordfxreferences🤖 Generated with Claude Code