fix: Wrap a few determinism holes#10303
Open
Bownairo wants to merge 5 commits into
Open
Conversation
fb57d6a to
cb94878
Compare
frankdavid
approved these changes
May 27, 2026
basvandijk
approved these changes
May 27, 2026
Collaborator
basvandijk
left a comment
There was a problem hiding this comment.
Wouldn't it be better to leave mkfs.vfat and mkfs.ext4 hermetic? The fewer deps we use from the env the easier it becomes to move to remote execution and the fewer risk of non-determinism.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #10277.
Simplify bootloader pinning, and remove the fs wrappers. Pin
zstdused within the build.In testing across the upgrade from #10208 (where these issues first appeared), I found that an upgraded
zstdin the build container is responsible for the differences as seen in https://github.com/dfinity/ic/actions/runs/26249865093/job/77264840363.This is most clear with
//ic-os/setupos/envs/prod:partition-config.tzst, since it is just an empty partition. The tars contained are the exact same. I've tested this with both the artifacts from CI, and ones built locally on either side of the upgrade.For example:
Inside the compressed format, the content checksum is the same, so even
zstdknows the files are the same.I guess the new
zstdis one byte worse on compression? 😅