Enable nullable reference types in WaitForAppDetection.cs#11713
Merged
simonrozsival merged 3 commits intoJun 23, 2026
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enable nullable reference types in WaitForAppDetection.cs
Enable nullable reference types in WaitForAppDetection.cs
Jun 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Opts the shipped WaitForAppDetection MSBuild task into nullable reference types to accurately represent that its cached getPackagesAsync task may be absent when no task object is registered.
Changes:
- Enabled nullable reference types in
WaitForAppDetection.csvia#nullable enable. - Marked the
getPackagesAsyncfield as nullable to match the existingnullguard inRunTaskAsync ().
simonrozsival
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opts the shipped
WaitForAppDetectionMSBuild task into nullable reference types, making explicit the existing contract that its single field can legitimately benull. Follows the conversion of its siblingDetectIfAppWasUninstalled.cs(#11598), which deferred this file.Changes
#nullable enableas the first line ofsrc/Xamarin.Android.Build.Debugging.Tasks/Tasks/WaitForAppDetection.cs.getPackagesAsyncnullable, reflecting thatGetRegisteredTaskObjectAssemblyLocal<T>returnsnullwhen nothing is registered:The existing
if (getPackagesAsync == null) return;guard inRunTaskAsync ()already covers thenullcase, so no further changes were needed. No null-forgiving (!) operator is used; the project targetsnetstandard2.0, soArgumentNullException.ThrowIfNullis not applicable.