[release/10.0.1xx] [tests] Treat missing expected cookie as transient network failure in TestNSurlSessionHandlerCookieContainerSetCookie#25627
Conversation
…stNSurlSessionHandlerCookieContainerSetCookie Agent-Logs-Url: https://github.com/dotnet/macios/sessions/08f85733-39b4-40c6-bcf5-d46ae2c50f48 Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>
…HandlerCookieContainerSetCookie Agent-Logs-Url: https://github.com/dotnet/macios/sessions/269d09e0-2844-4dfa-9c95-470afec2eead Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR updates a flaky network-dependent cookie test to treat a missing expected cookie as a transient CI failure, reducing intermittent CI failures in the System.Net.Http test suite for Apple platforms.
Changes:
- Adds a
hasExpectedCookieboolean and treats the “cookie missing” case as ignorable in CI. - Keeps the assertion for local runs so the test still fails outside CI when the expected cookie is not observed.
| if (!hasExpectedCookie) | ||
| TestRuntime.IgnoreInCI ("Transient network failure - ignore in CI"); |
✅ [PR Build #1869d5e] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #1869d5e] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [PR Build #1869d5e] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #1869d5e] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 175 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
rolfbjarne
deleted the
dev/rolf/backport-pr-25420-release/10.0.1xx-2026-06-03
branch
TestNSurlSessionHandlerCookieContainerSetCookieto treat missing expected cookie as transient network failure (ignore in CI)CookieContainerinspection after!completedguard to avoid concurrent access!completedand!hasExpectedCookieCI-ignore guards so real exceptions still fail the testFixes #25385.
Co-authored-by: rolfbjarne 249268+rolfbjarne@users.noreply.github.com
Backport of #25420.