[devops] Use ACES pools for PRs.#25760
Conversation
Flip the useACES template parameter to true for the PR entry points (build, simulator tests, and API diff), mirroring the CI entry points enabled in 4d39e1b. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Flip the useACES template parameter back to false for the CI entry points (build, simulator tests, and API diff). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR flips the Azure Pipelines useACES literal in the macios devops entry pipelines so that PR workflows run on the ACES shared pool, while CI workflows run on the traditional CI pool, aligning pool selection with the stated goal of using ACES for PRs and disabling it for CI.
Changes:
- Enable
useACES: truefor PR pipelines (build, api-diff, post-build tests). - Disable
useACES: falsefor CI pipelines (build, api-diff, post-build tests).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/devops/automation/run-pr-api-diff.yml | Routes PR API diff to ACES by setting useACES: true. |
| tools/devops/automation/run-post-pr-build-tests.yml | Routes PR simulator tests to ACES by setting useACES: true. |
| tools/devops/automation/run-post-ci-build-tests.yml | Routes CI simulator tests off ACES by setting useACES: false. |
| tools/devops/automation/run-ci-api-diff.yml | Routes CI API diff off ACES by setting useACES: false. |
| tools/devops/automation/build-pull-request.yml | Routes PR main build stages to ACES by setting useACES: true. |
| tools/devops/automation/build-pipeline.yml | Routes CI main build stages off ACES by setting useACES: false. |
| provisionatorChannel: ${{ parameters.provisionatorChannel }} | ||
| pool: $(CIBuildPool) | ||
| runGovernanceTests: ${{ parameters.runGovernanceTests }} | ||
| forceInsertion: ${{ parameters.forceInsertion }} | ||
| pushNugets: ${{ parameters.pushNugets }} | ||
| pushNugetsToMaestro: ${{ parameters.pushNugetsToMaestro }} | ||
| useACES: true # flip to false to opt CI out of ACES; see templates/variables/common.yml | ||
| useACES: false # flip to true to opt CI into ACES; see templates/variables/common.yml |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #9c8452f] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [PR Build #9c8452f] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [PR Build #9c8452f] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #9c8452f] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 2 tests failed, 197 tests passed. Failures❌ dotnettests tests (iOS) [attempt 3]1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS) [attempt 3]1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. [attempt 2] Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
And disable it for CI.