[tests] Fix expected value for 'RunCommand' after #25764.#25795
Open
rolfbjarne wants to merge 1 commit into
Open
[tests] Fix expected value for 'RunCommand' after #25764.#25795rolfbjarne wants to merge 1 commit into
rolfbjarne wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the .NET unit test suite to match the current MSBuild behavior for the RunCommand property when computing mlaunch run arguments (after #25764), ensuring the binlog assertion reflects the unquoted command path.
Changes:
- Adjusted
MlaunchTest.GetMlaunchRunArgumentsto expectRunCommandto equal$(MlaunchPath)(unquoted), matchingdotnet/targets/Microsoft.Sdk.Mobile.targetswhich sets<RunCommand>$(MlaunchPath)</RunCommand>.
Collaborator
✅ [PR Build #180d4fb] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
Collaborator
✅ [PR Build #180d4fb] Build passed (Build packages) ✅Pipeline on Agent |
Collaborator
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
Collaborator
✅ [PR Build #180d4fb] Build passed (Build macOS tests) ✅Pipeline on Agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.