[tests] Add back the app size test to see if it's better now.#25910
[tests] Add back the app size test to see if it's better now.#25910rolfbjarne wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Re-enables the .NET app bundle size regression test and updates the stored expected outputs (bundle size reports + preserved API lists) for iOS/tvOS/Mac Catalyst/macOS across MonoVM, interpreter, NativeAOT, and CoreCLR configurations.
Changes:
- Re-enable
AppSizeTestby removing the fixture-level ignore. - Refresh expected app bundle size baselines for multiple platform/runtime combinations.
- Refresh expected “preserved APIs” baselines for MonoVM/interpreter configurations.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/dotnet/UnitTests/AppSizeTest.cs | Re-enables the app size test by removing [Ignore]. |
| tests/dotnet/UnitTests/expected/TVOS-NativeAOT-TrimmableStatic-size.txt | Updates expected tvOS NativeAOT (trimmable-static registrar) bundle size report. |
| tests/dotnet/UnitTests/expected/TVOS-NativeAOT-size.txt | Updates expected tvOS NativeAOT bundle size report. |
| tests/dotnet/UnitTests/expected/TVOS-MonoVM-size.txt | Updates expected tvOS MonoVM bundle size report. |
| tests/dotnet/UnitTests/expected/TVOS-MonoVM-preservedapis.txt | Updates expected tvOS MonoVM preserved API set. |
| tests/dotnet/UnitTests/expected/TVOS-MonoVM-interpreter-size.txt | Updates expected tvOS MonoVM+interpreter bundle size report. |
| tests/dotnet/UnitTests/expected/TVOS-MonoVM-interpreter-preservedapis.txt | Updates expected tvOS MonoVM+interpreter preserved API set. |
| tests/dotnet/UnitTests/expected/MacOSX-NativeAOT-TrimmableStatic-size.txt | Updates expected macOS NativeAOT (trimmable-static registrar) bundle size report. |
| tests/dotnet/UnitTests/expected/MacOSX-NativeAOT-size.txt | Updates expected macOS NativeAOT bundle size report. |
| tests/dotnet/UnitTests/expected/MacOSX-CoreCLR-Interpreter-TrimmableStatic-size.txt | Updates expected macOS CoreCLR+interpreter (trimmable-static registrar) bundle size report. |
| tests/dotnet/UnitTests/expected/MacOSX-CoreCLR-Interpreter-size.txt | Updates expected macOS CoreCLR+interpreter bundle size report. |
| tests/dotnet/UnitTests/expected/MacCatalyst-NativeAOT-TrimmableStatic-size.txt | Updates expected Mac Catalyst NativeAOT (trimmable-static registrar) bundle size report. |
| tests/dotnet/UnitTests/expected/MacCatalyst-NativeAOT-size.txt | Updates expected Mac Catalyst NativeAOT bundle size report. |
| tests/dotnet/UnitTests/expected/MacCatalyst-MonoVM-size.txt | Updates expected Mac Catalyst MonoVM bundle size report. |
| tests/dotnet/UnitTests/expected/MacCatalyst-MonoVM-preservedapis.txt | Updates expected Mac Catalyst MonoVM preserved API set. |
| tests/dotnet/UnitTests/expected/MacCatalyst-MonoVM-interpreter-size.txt | Updates expected Mac Catalyst MonoVM+interpreter bundle size report. |
| tests/dotnet/UnitTests/expected/MacCatalyst-MonoVM-interpreter-preservedapis.txt | Updates expected Mac Catalyst MonoVM+interpreter preserved API set. |
| tests/dotnet/UnitTests/expected/iOS-NativeAOT-TrimmableStatic-size.txt | Updates expected iOS NativeAOT (trimmable-static registrar) bundle size report. |
| tests/dotnet/UnitTests/expected/iOS-NativeAOT-size.txt | Updates expected iOS NativeAOT bundle size report. |
| tests/dotnet/UnitTests/expected/iOS-MonoVM-size.txt | Updates expected iOS MonoVM bundle size report. |
| tests/dotnet/UnitTests/expected/iOS-MonoVM-preservedapis.txt | Updates expected iOS MonoVM preserved API set. |
| tests/dotnet/UnitTests/expected/iOS-MonoVM-interpreter-size.txt | Updates expected iOS MonoVM+interpreter bundle size report. |
| tests/dotnet/UnitTests/expected/iOS-MonoVM-interpreter-preservedapis.txt | Updates expected iOS MonoVM+interpreter preserved API set. |
| [TestFixture] | ||
| [Ignore ("The results depend on the macOS version of the bot running the test")] | ||
| public class AppSizeTest : TestBaseClass { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
When running in Azure DevOps CI and the AppSizeTest fails, copy the resulting .app bundle to BUILD_ARTIFACTSTAGINGDIRECTORY so it gets uploaded (zipped) as a build artifact for diagnostic purposes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Zip the .app bundle into a single zip file (instead of copying the directory tree), and add a sortable UTC timestamp to the zip file name so subsequent failing tests don't overwrite it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #dca0bf3] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #dca0bf3] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 1 tests failed, 198 tests passed. Failures❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #fee616b] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [PR Build #fee616b] Build passed (Build packages) ✅Pipeline on Agent |
No description provided.