web: exact-total search count badge + dependency bumps#24
Merged
Conversation
The grouped search count badge showed "(10+)" for any type that overflowed the 10-result quick-search cap, while the adjacent "View all N" link showed the exact total. The two figures disagreed for the same group. Show the exact total in the badge instead, comma-formatted, so it reads e.g. "Networks (1,234)" and matches the "View all" link. The total is already computed for overflowing types (it drives the link), so this adds no query. The terminal search header is aligned to the same exact total for cross-surface parity, replacing its own "(N+ results)" form. The single count helper is exported as templates.FormatThousands so the termrender package can reuse it; the now-unused hasMoreSuffix helper is removed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Routine maintenance bumps of the two direct dependencies with available updates: golang.org/x/sync v0.20.0 -> v0.21.0 and modernc.org/sqlite v1.51.0 -> v1.52.0. Neither is a code-generation tool, so generated code is unaffected; the full race suite and govulncheck pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Capture the exact-total search count badge (Changed) and the dependency bumps (Dependencies) under a 1.20.1 section. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Code Metrics Report
Code coverage of files in pull request scope (93.8%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small things, batched into one release (v1.20.1):
Exact-total search count badge. The grouped search badge showed
(10+)for any type over the 10-result quick-search cap, disagreeing with the adjacent "View all N" link's exact figure. The badge now shows the same exact, comma-formatted total (e.g.Networks (1,234)). The total is already computed for overflowing types (it drives the link), so no extra query. The terminal search header (curl/plain UAs) is aligned to the same exact total for parity. The count helper is exported astemplates.FormatThousandsfor reuse; the now-unusedhasMoreSuffixis removed.Dependency bumps.
golang.org/x/syncv0.20.0 → v0.21.0 andmodernc.org/sqlitev1.51.0 → v1.52.0 — the two direct deps with available updates. Neither is a codegen tool, so generated code is unaffected.Verification
go build,go test -race ./...,go vet,golangci-lint runall pass;go generate ./...drift-clean (only the two intended templ files);govulncheck ./...→ no vulnerabilities.🤖 Generated with Claude Code