web: align search-result flags (city before country flag)#25
Merged
Conversation
The search result location rendered the country flag first, then the city. Because the metadata block is flush-right, the city (the rightmost element) right-aligned while the flag floated at a position determined by the city text width, so flags did not line up down the result list. Render the city first and the flag last. The fixed-width flag is now the rightmost element, so flags align on the right edge across all rows, and network rows' "ASxxxx" aligns to the same edge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Capture the search-result city-before-flag ordering change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Code Metrics Report
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In search results the country flag was rendered before the city. Because the metadata block is flush-right, the city (rightmost element) right-aligned while the flag floated at a city-width-dependent position, so flags didn't line up down the list.
Render the city first, flag last. The fixed-width flag becomes the rightmost element, so flags align on the right edge across all rows (network rows'
AS…align to the same edge). One-line template reorder in the sharedSearchRowcomponent, so it fixes both the grouped quick-search and the per-type "view all" page.Rolls v1.20.2.
Verification
go build,go test -race ./...(web),go vet,golangci-lint runpass;go generate ./...drift-clean. Render check confirms the metadata order is now[city] [flag].🤖 Generated with Claude Code