lib-mail: mbox-from - Fix out-of-bounds read of year field#296
Open
nishat-06 wants to merge 1 commit into
Open
lib-mail: mbox-from - Fix out-of-bounds read of year field#296nishat-06 wants to merge 1 commit into
nishat-06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mbox_from_parse only checks the minimum date length up front, but the year field is read after a variable number of optional fields (seconds, named or numeric timezone) have been consumed. A From_ line that ends right after those fields leaves msg at msg_end, so mbox_parse_year reads up to four bytes past the buffer. Bound the read against msg_end before parsing the year, matching the msg_end guards used for the other fields. The added test feeds an exact-size heap buffer so the over-read is caught under valgrind/ASAN.