Skip to content

Skip 3 test262 tests that consistently time out#488

Open
dowdiness wants to merge 1 commit into
mainfrom
fix/test262-timeout-skips
Open

Skip 3 test262 tests that consistently time out#488
dowdiness wants to merge 1 commit into
mainfrom
fix/test262-timeout-skips

Conversation

@dowdiness

@dowdiness dowdiness commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Summary

Three test262 tests consistently time out at the default 10s per-test timeout. The engine computes the correct result for all three; the timeout is a workload issue, not an engine bug. Adding runner-level skip_path_suffixes entries avoids executing them.

Tests skipped

Test Issue Runtime at 120s timeout
built-in-function-object.js Recursively walks ALL intrinsic objects via getOwnPropertyDescriptors + Reflect.ownKeys, calling toString() on every function found 16.8s
S15.1.3.1_A2.5_T1.js 1.3M-iteration Sputnik test enumerating all valid 4-byte UTF-8 sequences 35.7s
S15.1.3.2_A2.5_T1.js Same 1.3M-iteration Sputnik test for decodeURIComponent 35.7s

Verification

  • make test262-validate-skips: ok (53495 files scanned)
  • make test262-filter FILTER=Function/prototype/toString: 130/130 pass, 0 timeouts
  • make test262-filter FILTER=decodeURI: 212/218 pass (6 pre-existing failures unrelated to timeouts), 0 timeouts
  • moon check && moon test: 2276/2276 pass

Summary by CodeRabbit

  • Chores
    • Updated test metadata to skip a few known slow or timing-sensitive test cases.
    • Added timeout-based exclusions for specific runtime and URI decoding test files to reduce noisy test runs.

These tests take 16-36s to pass, far exceeding the default 10s timeout:
- built-ins/Function/prototype/toString/built-in-function-object.js:
  Recursively walks all intrinsic objects via getOwnPropertyDescriptors
  (16.8s at 120s timeout)
- built-ins/decodeURI/S15.1.3.1_A2.5_T1.js:
  1.3M-iteration Sputnik test for 4-byte UTF-8 sequences
  (35.7s at 120s timeout)
- built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js:
  Same 1.3M-iteration Sputnik test for decodeURIComponent
  (35.7s at 120s timeout)

The engine computes the correct result for all three; the timeout is a
test framework workload issue, not an engine bug. Adding runner-internal
skip_path_suffixes entries skips them before execution.
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 43be9d28-7ad9-447f-86db-79dfbd78c260

📥 Commits

Reviewing files that changed from the base of the PR and between 2d45c8d and c034d4a.

📒 Files selected for processing (1)
  • scripts/test262_skip_metadata.json

📝 Walkthrough

Walkthrough

This change updates a JSON configuration file used for test262 test skipping, populating a previously empty skip_path_suffixes object with three entries mapping specific test file path suffixes to timeout-related skip reasons.

Changes

Test262 skip metadata update

Layer / File(s) Summary
Add skip path suffix entries
scripts/test262_skip_metadata.json
Populates skip_path_suffixes with three entries for Function.prototype.toString and decodeURI/decodeURIComponent tests, each with a "Timeout" reason.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: test262, config

Suggested reviewers: dowdiness

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: skipping three consistently timing-out test262 tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/test262-timeout-skips

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant