Skip 3 test262 tests that consistently time out#488
Open
dowdiness wants to merge 1 commit into
Open
Conversation
These tests take 16-36s to pass, far exceeding the default 10s timeout: - built-ins/Function/prototype/toString/built-in-function-object.js: Recursively walks all intrinsic objects via getOwnPropertyDescriptors (16.8s at 120s timeout) - built-ins/decodeURI/S15.1.3.1_A2.5_T1.js: 1.3M-iteration Sputnik test for 4-byte UTF-8 sequences (35.7s at 120s timeout) - built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js: Same 1.3M-iteration Sputnik test for decodeURIComponent (35.7s at 120s timeout) The engine computes the correct result for all three; the timeout is a test framework workload issue, not an engine bug. Adding runner-internal skip_path_suffixes entries skips them before execution.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change updates a JSON configuration file used for test262 test skipping, populating a previously empty ChangesTest262 skip metadata update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: test262, config Suggested reviewers: dowdiness 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three test262 tests consistently time out at the default 10s per-test timeout. The engine computes the correct result for all three; the timeout is a workload issue, not an engine bug. Adding runner-level
skip_path_suffixesentries avoids executing them.Tests skipped
built-in-function-object.jsgetOwnPropertyDescriptors+Reflect.ownKeys, callingtoString()on every function foundS15.1.3.1_A2.5_T1.jsS15.1.3.2_A2.5_T1.jsdecodeURIComponentVerification
make test262-validate-skips: ok (53495 files scanned)make test262-filter FILTER=Function/prototype/toString: 130/130 pass, 0 timeoutsmake test262-filter FILTER=decodeURI: 212/218 pass (6 pre-existing failures unrelated to timeouts), 0 timeoutsmoon check && moon test: 2276/2276 passSummary by CodeRabbit