Skip to content

Installer v7.6 robustness: resume preflight + safer extension failure flow#582

Open
nicdavidson wants to merge 11 commits into
developfrom
installer/v7.6-robustness-overhaul
Open

Installer v7.6 robustness: resume preflight + safer extension failure flow#582
nicdavidson wants to merge 11 commits into
developfrom
installer/v7.6-robustness-overhaul

Conversation

@nicdavidson
Copy link
Copy Markdown
Contributor

@nicdavidson nicdavidson commented Jun 1, 2026

Summary

  • add Debian/Ubuntu package-manager health preflight before installer pipeline continues
  • recover interrupted dpkg state by running dpkg --configure -a and apt-get -f install -y when dpkg --audit reports issues
  • prevent hard process termination in Ubuntu PECL helper failures (install_mcrypt, install_mongodb) by returning non-zero instead of killing/exiting

Why

  • rerun/resume should survive partial package-manager interruption instead of cascading into ambiguous failures
  • helper functions should not kill the orchestrator unexpectedly during sourced execution paths

Validation

  • bash -n installer.sh
  • for f in installers/source/*.sh; do bash -n "$f"; done
  • branch pushed and ready for review

Notes

  • full VM matrix execution is still required for final sign-off (Ubuntu/Debian/RHEL-family happy path + induced failure + resume).

@nicdavidson
Copy link
Copy Markdown
Contributor Author

Added follow-up hardening commit: \n\nWhat it fixes:\n- now kills the actual spinner PID () instead of \n- INT trap now safely kills spinner PID with stderr suppressed\n- command invocation uses quoted function name call ()\n\nExtra verification run:\n- \n- \n- focused runtime harness confirmed no orphan spinner child processes after success/failure paths ()\n\nRemaining for full sign-off: distro VM matrix (Ubuntu/Debian/RHEL families with induced failure + resume).

@nicdavidson
Copy link
Copy Markdown
Contributor Author

Follow-up hardening commit pushed: 48f2779

What it fixes:

  • run_process now kills the actual spinner PID ($BGPID) instead of kill $!
  • INT trap now safely kills spinner PID with stderr suppressed
  • command invocation uses quoted function name call ("$2")

Extra verification run:

  • bash -n installer.sh
  • for f in installers/source/*.sh; do bash -n "$f"; done
  • focused runtime harness confirmed no orphan spinner child processes after success/failure paths (child_sleep_count=0)

Remaining for full sign-off: distro VM matrix (Ubuntu/Debian/RHEL families with induced failure + resume).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant