Installer v7.6 robustness: resume preflight + safer extension failure flow#582
Open
nicdavidson wants to merge 11 commits into
Open
Installer v7.6 robustness: resume preflight + safer extension failure flow#582nicdavidson wants to merge 11 commits into
nicdavidson wants to merge 11 commits into
Conversation
Contributor
Author
|
Added follow-up hardening commit: \n\nWhat it fixes:\n- now kills the actual spinner PID () instead of \n- INT trap now safely kills spinner PID with stderr suppressed\n- command invocation uses quoted function name call ()\n\nExtra verification run:\n- \n- \n- focused runtime harness confirmed no orphan spinner child processes after success/failure paths ()\n\nRemaining for full sign-off: distro VM matrix (Ubuntu/Debian/RHEL families with induced failure + resume). |
Contributor
Author
|
Follow-up hardening commit pushed: 48f2779 What it fixes:
Extra verification run:
Remaining for full sign-off: distro VM matrix (Ubuntu/Debian/RHEL families with induced failure + resume). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dpkg --configure -aandapt-get -f install -ywhendpkg --auditreports issuesinstall_mcrypt,install_mongodb) by returning non-zero instead of killing/exitingWhy
Validation
bash -n installer.shfor f in installers/source/*.sh; do bash -n "$f"; doneNotes