Skip to content

Puppet 5 is released. Make case statement future proof#103

Open
rgevaert wants to merge 1 commit into
drwahl:masterfrom
rgevaert:puppet5support
Open

Puppet 5 is released. Make case statement future proof#103
rgevaert wants to merge 1 commit into
drwahl:masterfrom
rgevaert:puppet5support

Conversation

@rgevaert

Copy link
Copy Markdown
Contributor

Fixes #102

Comment thread pre-commit
# Only puppet 3.2.1 - 3.8 support "--parser future" option.
case $(puppet --version) in
4*) USE_PUPPET_FUTURE_PARSER="disabled" ;;
3.[2-8]*) USE_PUPPET_FUTURE_PARSER="enabled" ;;

@pillarsdotnet pillarsdotnet Aug 29, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-# Only puppet 3.2.1 - 3.8 support "--parser future" option.
+# Only puppet 3.1.1 - 3.8.7 support "--parser future" option.
 case $(puppet --version) in
-  4*) USE_PUPPET_FUTURE_PARSER="disabled" ;;
+  3.1.[1-9]*) ;&
+  3.[2-8]*) USE_PUPPET_FUTURE_PARSER="enabled" ;;
+  *) USE_PUPPET_FUTURE_PARSER="disabled" ;;
 esac

The "--parser=future" command-line setting was added in version 3.1.1 (See lib/puppet/version.rb and lib/puppet/defaults.rb).

@nicollet

nicollet commented Sep 4, 2017

Copy link
Copy Markdown

Please merge this one, at it would be quite valuable to most :-) Also, apparently puppet4/5 are not installed by default in the bundle. Sad.

@pozgo

pozgo commented Dec 29, 2017

Copy link
Copy Markdown

for puppet 5.x should be like example below.

5*) USE_PUPPET_FUTURE_PARSER="disabled" ;;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants