Skip to content

Discount icon change#3903

Open
marcusljf wants to merge 2 commits into
mainfrom
discount-code-icon
Open

Discount icon change#3903
marcusljf wants to merge 2 commits into
mainfrom
discount-code-icon

Conversation

@marcusljf
Copy link
Copy Markdown
Collaborator

@marcusljf marcusljf commented May 13, 2026

Updated on the partner details discount code section

CleanShot 2026-05-13 at 16 39 24@2x CleanShot 2026-05-13 at 16 39 18@2x

Summary by CodeRabbit

  • New Features

    • Added a new DiscountCode icon component to the UI library.
  • Style

    • Replaced prior tag icon usage across partner discount screens and modals with the new DiscountCode icon (empty states, input adornments, badges, and verification/confirmation pill).

Review Change Stack

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dub Ready Ready Preview May 14, 2026 2:25am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3b8fde78-709e-4d72-b407-e5bbe6e7b8bd

📥 Commits

Reviewing files that changed from the base of the PR and between 3f7ba76 and 1dba3b2.

📒 Files selected for processing (2)
  • apps/web/ui/modals/delete-discount-code-modal.tsx
  • apps/web/ui/partners/discounts/discount-code-badge.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • apps/web/ui/partners/discounts/discount-code-badge.tsx
  • apps/web/ui/modals/delete-discount-code-modal.tsx

📝 Walkthrough

Walkthrough

Adds a new 18×18 DiscountCode SVG icon to the UI package and replaces previous Tag icon imports/usages with DiscountCode in four discount-code-related app components.

Changes

DiscountCode Icon Component and Migration

Layer / File(s) Summary
Create and export DiscountCode icon component
packages/ui/src/icons/nucleo/discount-code.tsx, packages/ui/src/icons/nucleo/index.ts
A new DiscountCode SVG component is added (typed, 18×18, currentColor) and re-exported from the nucleo icons index.
Update discount-code UI components to use DiscountCode
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/[partnerId]/links/page.tsx, apps/web/ui/modals/add-discount-code-modal.tsx, apps/web/ui/modals/delete-discount-code-modal.tsx, apps/web/ui/partners/discounts/discount-code-badge.tsx
Replace Tag imports/usages with DiscountCode in empty-state UI, add-discount modal input icon, delete-confirm verification pill, and the discount-code badge button; existing behavior (copy, delete flow, toasts) is unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • pepeladeira
  • steven-tey

Poem

🐰 I hopped in with a tiny tag so bright,
Swapped it for DiscountCode by starlit night,
Circles and a line in SVG cheer,
Four spots updated — now the icon's here,
Hoppity hop, the UI's light ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Discount icon change' accurately describes the main change: replacing the Tag icon with a DiscountCode icon across multiple files in the discount code feature.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch discount-code-icon

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/ui/modals/delete-discount-code-modal.tsx

Parsing error: The keyword 'import' is reserved

apps/web/ui/partners/discounts/discount-code-badge.tsx

Parsing error: The keyword 'import' is reserved


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@marcusljf
Copy link
Copy Markdown
Collaborator Author

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

✅ Actions performed

Full review triggered.

@marcusljf marcusljf changed the title Icon updates Discount icon change May 14, 2026
@marcusljf
Copy link
Copy Markdown
Collaborator Author

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

✅ Actions performed

Full review triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant