Skip to content

chore: update node script to accept miscs #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
43081j merged 1 commit into from
Jul 3, 2026
+33 −15
Merged

chore: update node script to accept miscs #769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 33 additions & 15 deletions scripts/update-engines-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,16 @@ interface DocumentedNodeClass {
classMethods?: Array<DocumentedNodeClassMethod | DocumentedUnknownNode>;
}

interface DocumentedNodeMisc {
type: 'misc';
name: string;
modules?: Array<DocumentedNodeModule | DocumentedUnknownNode>;
classes?: Array<DocumentedNodeClass | DocumentedUnknownNode>;
properties?: Array<DocumentedNodeProperty>;
methods?: Array<DocumentedNodeMethod | DocumentedUnknownNode>;
miscs?: Array<DocumentedNodeMisc | DocumentedUnknownNode>;
}

interface DocumentedNodeGlobal {
type: 'global';
name: string;
Expand All @@ -52,6 +62,7 @@ interface DocumentedNodeGlobal {
classes?: Array<DocumentedNodeClass | DocumentedUnknownNode>;
properties?: Array<DocumentedNodeProperty>;
methods?: Array<DocumentedNodeMethod | DocumentedUnknownNode>;
miscs?: Array<DocumentedNodeMisc | DocumentedUnknownNode>;
}

interface DocumentedNodeModule {
Expand All @@ -63,6 +74,7 @@ interface DocumentedNodeModule {
classes?: Array<DocumentedNodeClass | DocumentedUnknownNode>;
properties?: Array<DocumentedNodeProperty>;
methods?: Array<DocumentedNodeMethod | DocumentedUnknownNode>;
miscs?: Array<DocumentedNodeMisc | DocumentedUnknownNode>;
globals?: Array<DocumentedNodeGlobal | DocumentedUnknownNode>;
}

Expand Down Expand Up @@ -127,34 +139,33 @@ function earliestVersion(versions: string[]): string {
}

function findExportVersion(
module: DocumentedNodeModule | DocumentedNodeGlobal,
module: DocumentedNodeModule | DocumentedNodeGlobal | DocumentedNodeMisc,
exportName: string,
lastIntroducedIn?: string
lastIntroducedIn: string | null
): string | null {
const introducedIn =
module.introduced_in?.replace(/^v/, '') ?? lastIntroducedIn;
let introducedIn: string | null = lastIntroducedIn;
if (module.type !== 'misc' && module.introduced_in) {
introducedIn = module.introduced_in.replace(/^v/, '');
}

for (const item of module.methods ?? []) {
if (item.type === 'method' && item.name === exportName) {
return item.meta?.added
? earliestVersion(item.meta.added)
: (introducedIn ?? null);
return item.meta?.added ? earliestVersion(item.meta.added) : introducedIn;
}
}

for (const item of module.properties ?? []) {
if (item.name === exportName) {
return item.meta?.added
? earliestVersion(item.meta.added)
: (introducedIn ?? null);
return item.meta?.added ? earliestVersion(item.meta.added) : introducedIn;
}
}

for (const item of module.classes ?? []) {
if (item.type === 'class' && item.name === exportName) {
return item.meta?.added
? earliestVersion(item.meta.added)
: (introducedIn ?? null);
if (
item.type === 'class' &&
(item.name === exportName || item.name.endsWith(`.${exportName}`))
) {
return item.meta?.added ? earliestVersion(item.meta.added) : introducedIn;
}
}

Expand All @@ -165,6 +176,13 @@ function findExportVersion(
}
}

for (const misc of module.miscs ?? []) {
if (misc.type === 'misc') {
const found = findExportVersion(misc, exportName, introducedIn);
if (found) return found;
}
}

return null;
}

Expand Down Expand Up @@ -228,7 +246,7 @@ async function getNodeVersion(
return null;
}

return findExportVersion(root, exportName);
return findExportVersion(root, exportName, null);
}

async function updateReplacementNodeEngine(
Expand Down