Expose per-peer committed log index in peer_info#656
Open
xiaoxichen wants to merge 1 commit into
Open
Conversation
Add `last_committed_idx_` to `raft_server::peer_info` so callers can detect peers that have appended logs but cannot commit them (e.g., due to deadlocked commit threads). The value is populated from the existing `peer::get_sm_committed_idx()` and is meaningful only when `raft_params::track_peers_sm_commit_idx_` is enabled. Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
xiaoxichen
force-pushed
the
xiaoxchen/expose-peer-commit-idx
branch
from
c3bde2a to
1c259f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
last_committed_idx_toraft_server::peer_infoso callers can detect peers that have appended logs but cannot commit them (e.g., due to deadlocked commit threads). The value is populated from the existingpeer::get_sm_committed_idx()and is meaningful only whenraft_params::track_peers_sm_commit_idx_is enabled.