Report a bitcoind client version in getnetworkinfo.#8
Open
echennells wants to merge 1 commit into
Open
Conversation
echennells
force-pushed
the
bitcoind-getnetworkinfo-version
branch
2 times, most recently
from
4e64d64 to
25fcc36
Compare
echennells
force-pushed
the
bitcoind-getnetworkinfo-conformance
branch
from
4f7c000 to
39b4d92
Compare
echennells
force-pushed
the
bitcoind-getnetworkinfo-version
branch
from
25fcc36 to
6b33dcc
Compare
echennells
force-pushed
the
bitcoind-getnetworkinfo-conformance
branch
from
39b4d92 to
14ee154
Compare
echennells
force-pushed
the
bitcoind-getnetworkinfo-version
branch
from
6b33dcc to
2885dc1
Compare
echennells
force-pushed
the
bitcoind-getnetworkinfo-conformance
branch
from
14ee154 to
4edd650
Compare
echennells
force-pushed
the
bitcoind-getnetworkinfo-version
branch
from
2885dc1 to
e4f2675
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getnetworkinforeportsversion: 0. Typed clients of the bitcoind RPC — rust-bitcoincore-rpc, and the tools built on it such as ord and BDK — read this field and treat any value below 190000 as a pre-0.19 daemon, switching to a legacy parse path this interface does not emit. The client aborts during startup, before any other field is consulted.This reports
280000, which clears the startup path. The value is a placeholder pending the decision below; a// TODO:marks deriving it from settings.Decision requested: should the bitcoind RPC report a version integer at all — reporting one claims a specific daemon version — and if so, should the value be fixed (
280000), operator-configurable, or tracked to a target release? This is the only field in thegetnetworkinfoset that needs a policy decision rather than a mechanical fix.Testing:
getnetworkinfo__fieldsassertsversionis an integer>= 190000. Full suite green (make check, 534 cases) on a synced testnet3 node.