Skip to content

Handle "Workspace Trust" popup in VS Code Editor E2E typescript tests#23907

Merged
dmytro-ndp merged 2 commits into
eclipse-che:mainfrom
SkorikSergey:handleWorkspaceTrusPopup
Jul 8, 2026
Merged

Handle "Workspace Trust" popup in VS Code Editor E2E typescript tests#23907
dmytro-ndp merged 2 commits into
eclipse-che:mainfrom
SkorikSergey:handleWorkspaceTrusPopup

Conversation

@SkorikSergey

@SkorikSergey SkorikSergey commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

We need to fix E2E typescript tests which failed because didn’t handle properly following popups:
8606f131-9abd-44e6-9350-7da5efe0f926

Also add the SshUrlNoOauthPatFactory test stabilization fix.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://redhat.atlassian.net/browse/CRW-11675

How to test this PR?

Validated on SshUrlNoOauthPatFactory e2e test:

        ‣ DriverHelper.waitAndClick - By(css selector, *[id="status\.workspaceTrust"])
        ‣ DriverHelper.waitVisibility - By(css selector, *[id="status\.workspaceTrust"])
        ‣ DriverHelper.waitVisibility - element is located and is visible.
        ‣ DriverHelper.waitAndClick - By(xpath, //a[@role="button" and text()="Trust"])
        ‣ DriverHelper.waitVisibility - By(xpath, //a[@role="button" and text()="Trust"])
        ‣ DriverHelper.waitVisibility - element is located and is visible.
            RestrictedModeButton.closeRestrictedModeWindow
        ‣ DriverHelper.waitAndClick - By(css selector, a[aria-label="Close Modal Editor (Escape)"])
        ‣ DriverHelper.waitVisibility - By(css selector, a[aria-label="Close Modal Editor (Escape)"])
        ‣ DriverHelper.waitVisibility - element is located and is visible.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@dmytro-ndp dmytro-ndp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SkorikSergey
SkorikSergey marked this pull request as ready for review July 8, 2026 14:19
@dmytro-ndp
dmytro-ndp merged commit 38dc0b7 into eclipse-che:main Jul 8, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants