refactor(plantuml): replace linker with idmap-based cross-diagram linking#290
Open
AAmbuj wants to merge 1 commit into
Open
refactor(plantuml): replace linker with idmap-based cross-diagram linking#290AAmbuj wants to merge 1 commit into
AAmbuj wants to merge 1 commit into
Conversation
AAmbuj
requested review from
LittleHuba,
castler,
hoe-jo,
limdor and
ramceb
as code owners
AAmbuj
force-pushed
the
amsh_plantuml_linker_review_refactor
branch
from
dbb35d4 to
6b7cf91
Compare
…king Replace the separate linker tool with idmap sidecar files emitted directly by the parser. Key changes: - Add puml_idmap crate: emits *.idmap.json sidecars with defines/references roles detected from diagram structure (component children, class methods/ variables, sequence participants) - Extend puml_cli with --source-name and --idmap-output-dir args; use the workspace-relative path identity instead of the basename for a stable, path-unique source identifier - Rewrite clickable_plantuml Sphinx extension: load idmaps at builder-inited, resolve references via FQN→alias lookup with a proximity tiebreak and a tie→no-link guard; emit correct relative URLs for svg_obj mode; and percent-encode injected PlantUML URLs - Update architectural_design.bzl: parser now emits 3 outputs (fbs, lobster, idmap); remove linker action and _linker attr - Delete plantuml/linker (replaced by idmap approach)
AAmbuj
force-pushed
the
amsh_plantuml_linker_review_refactor
branch
from
6b7cf91 to
024b9b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the separate linker tool with idmap sidecar files emitted directly by the parser.
Key changes: