Enhance GitHub Actions workflow#3
Conversation
Signed-off-by: Sachin Kumar <sachinkum123567@gmail.com>
|
Hi @sophokles73 |
sophokles73
left a comment
sophokles73
left a comment
There was a problem hiding this comment.
Thanks for adding a first CI workflow.
In general, we use dedicated workflows for different tasks, e.g. we usually have a workflow for performing checks on PRs, which verifies formatting rules, successful tests, coverage etc.
We then also have dedicated workflows for creating and publishing a release. You might want to take a look at the up-rust repo for some inspiration.
| @@ -0,0 +1,126 @@ | |||
| name: CI | |||
There was a problem hiding this comment.
Can you please add the license header as we use in the other repos?
| - name: Upload wheels | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: wheels-linux-${{ matrix.platform.target }} | ||
| path: dist |
There was a problem hiding this comment.
IMHO we do not need to upload the built binaries to the workflow.
There was a problem hiding this comment.
Thanks, I will remove this from the workflow.
Co-authored-by: Kai Hudalla <sophokles.kh@gmail.com>
|
Made this PR draft for now, will make it ready for review once its done. |
2 participants
Github Actions Workflow added to include the CI/CD workflow, which can build, test and release python wheels.
This PR is related to the issue #2