Support for marker kubebuilder:validation:Required/Optional#201
Open
swathinsankaran wants to merge 1 commit into
Open
Support for marker kubebuilder:validation:Required/Optional#201swathinsankaran wants to merge 1 commit into
swathinsankaran wants to merge 1 commit into
Conversation
The doc created for the markers Required/Optional were having
invalid characters that was resulting in the improper parsing
and rendering the created document.
Details of the change:
- Adds full support for the markers kubebuilder:validation:Required
and kubebuilder:validation:Optional.
- Fixes the errors seen in unit tests due to the change in the format.
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #198
Summary
The doc created for the markers Required/Optional had invalid characters that resulted in improper parsing and rendering of the created document.
Details
The parser did not have the logic to parse the Required/Optional markers. The commit adds the logic as well as corrects the invalid character that resulted in improper rendering of the created document.
Changes