Skip to content

[splunk/alert] - Keep non-numeric proto as ECS field network.transport#20005

Open
ShourieG wants to merge 2 commits into
elastic:mainfrom
ShourieG:splunk/fix_7303
Open

[splunk/alert] - Keep non-numeric proto as ECS field network.transport#20005
ShourieG wants to merge 2 commits into
elastic:mainfrom
ShourieG:splunk/fix_7303

Conversation

@ShourieG

@ShourieG ShourieG commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Type of change

  • Bug

Proposed commit message

splunk/alert: keep non-numeric proto as network.transport

The convert_proto_to_long processor forced splunk.alert.proto to a
long. Palo Alto Networks and other CEF sources send a transport name
such as "tcp" in this field, so the conversion failed, appended to
error.message, tagged the event as pipeline_error, and dropped the
value.

Handle the non-numeric case instead of failing: copy the value to ECS
network.transport (lowercased) and remove splunk.alert.proto without
recording an error. Numeric values still convert to long, so the field
mapping is unchanged and the fix is not a breaking change.

Add a synthetic pipeline regression test covering both a protocol name
and a numeric protocol number.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

The convert_proto_to_long processor forced splunk.alert.proto to a
long. Palo Alto Networks and other CEF sources send a transport name
such as "tcp" in this field, so the conversion failed, appended to
error.message, tagged the event as pipeline_error, and dropped the
value.

Handle the non-numeric case instead of failing: copy the value to ECS
network.transport (lowercased) and remove splunk.alert.proto without
recording an error. Numeric values still convert to long, so the field
mapping is unchanged and the fix is not a breaking change.

Add a synthetic pipeline regression test covering both a protocol name
and a numeric protocol number.

Updates elastic/sdh-beats#7303
@ShourieG ShourieG self-assigned this Jul 7, 2026
@ShourieG ShourieG added integration Label used for meta issues tracking each integration bugfix Pull request that fixes a bug issue Integration:splunk Splunk labels Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Elastic Docs Style Checker (Vale)

Summary: 1 warning found

⚠️ Warnings (1): Fix when the suggestion improves clarity or correctness.
File Line Rule Message
packages/splunk/changelog.yml 4 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'.

The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@ShourieG ShourieG marked this pull request as ready for review July 7, 2026 06:19
@ShourieG ShourieG requested review from a team as code owners July 7, 2026 06:19
@ShourieG ShourieG added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Jul 7, 2026
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

✅ All changelog entries have the correct PR link.

@vera-review-bot

Copy link
Copy Markdown

No issues across the latest commits ce3898c.

A new commit triggers another review — at most once every 15 minutes. I skip the PR while it's approved or has merge conflicts.

🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth doing an IANA protocol number look-up if the convert succeeds? This would bring parity to the two forms.

@ShourieG ShourieG Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this would mean we would need a reverse lookup when convert fails right ?

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

cc @ShourieG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:splunk Splunk integration Label used for meta issues tracking each integration Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants