[splunk/alert] - Keep non-numeric proto as ECS field network.transport#20005
[splunk/alert] - Keep non-numeric proto as ECS field network.transport#20005ShourieG wants to merge 2 commits into
proto as ECS field network.transport#20005Conversation
The convert_proto_to_long processor forced splunk.alert.proto to a long. Palo Alto Networks and other CEF sources send a transport name such as "tcp" in this field, so the conversion failed, appended to error.message, tagged the event as pipeline_error, and dropped the value. Handle the non-numeric case instead of failing: copy the value to ECS network.transport (lowercased) and remove splunk.alert.proto without recording an error. Numeric values still convert to long, so the field mapping is unchanged and the fix is not a breaking change. Add a synthetic pipeline regression test covering both a protocol name and a numeric protocol number. Updates elastic/sdh-beats#7303
Elastic Docs Style Checker (Vale)Summary: 1 warning found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/splunk/changelog.yml | 4 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
|
✅ All changelog entries have the correct PR link. |
|
No issues across the latest commits ce3898c.
🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills
|
There was a problem hiding this comment.
Is it worth doing an IANA protocol number look-up if the convert succeeds? This would bring parity to the two forms.
There was a problem hiding this comment.
But this would mean we would need a reverse lookup when convert fails right ?
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @ShourieG |
Type of change
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots