fix(wab): stop expected client errors from logging at ERROR level#379
Open
jameswillis99 wants to merge 1 commit into
Open
fix(wab): stop expected client errors from logging at ERROR level#379jameswillis99 wants to merge 1 commit into
jameswillis99 wants to merge 1 commit into
Conversation
CSRF failures, expired sessions, and other routine client errors were paging PagerDuty because addEndErrorHandlers decided log severity before normalizing the error to its real status code, and several auth call sites logged expected client failures unconditionally at ERROR (including on successful OAuth callbacks). Reclassify these as warn/info and normalize before choosing severity so 4xx conditions no longer alert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSRF failures, expired sessions, and other routine client errors were paging PagerDuty because addEndErrorHandlers decided log severity before normalizing the error to its real status code, and several auth call sites logged expected client failures unconditionally at ERROR (including on successful OAuth callbacks). Reclassify these as warn/info and normalize before choosing severity so 4xx conditions no longer alert.