Skip to content

fix: use testName/testSubType filters instead of hidden testCategory column#2307

Open
sravankumarkunadi wants to merge 1 commit into
elementary-data:masterfrom
sravankumarkunadi:fix/dashboard-test-category-filter
Open

fix: use testName/testSubType filters instead of hidden testCategory column#2307
sravankumarkunadi wants to merge 1 commit into
elementary-data:masterfrom
sravankumarkunadi:fix/dashboard-test-category-filter

Conversation

@sravankumarkunadi

@sravankumarkunadi sravankumarkunadi commented Jul 23, 2026

Copy link
Copy Markdown

Description

Fixes #2294

Clicking a test category tile on the Dashboard (e.g. "Anomalies", "Volume") navigates to the Test Results tab with a testCategory filter applied. However, testCategory is a hidden column that is never populated from row data, so the filter matches no rows and the tab appears empty.

This removes the testCategory shortcut from Y0n and falls back to the existing testName/testSubType filter logic, which correctly matches the data in the Test Results table.

Summary by CodeRabbit

  • Bug Fixes
    • Updated test filtering to rely on test name and optional subtype criteria.
    • Removed automatic filtering by test category to improve filter accuracy.

@github-actions

Copy link
Copy Markdown
Contributor

👋 @sravankumarkunadi
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 53c8aa5e-5f34-406a-ae4a-10e4ebd7ef14

📥 Commits

Reviewing files that changed from the base of the PR and between 594b89d and 5db4ea0.

📒 Files selected for processing (1)
  • elementary/monitor/data_monitoring/report/index.html

📝 Walkthrough

Walkthrough

The dashboard filter-construction helper now omits testCategory filters and uses testName with an optional testSubType constraint.

Changes

Dashboard filter correction

Layer / File(s) Summary
Test result filter mapping
elementary/monitor/data_monitoring/report/index.html
Y0n no longer emits testCategory equality filters and instead constructs filters from testName and optional testSubType.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: elazarlachkar

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: replacing hidden testCategory filtering with testName/testSubType filters.
Linked Issues check ✅ Passed The change addresses #2294 by removing the empty testCategory filter path and relying on testName/testSubType filters.
Out of Scope Changes check ✅ Passed No unrelated code changes are evident from the provided summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.44.1)
elementary/monitor/data_monitoring/report/index.html

ast-grep timed out on this file


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sravankumarkunadi

Copy link
Copy Markdown
Author

This is a patch to the bundled index.html no source-level tests or docs apply here since the UI is built separately. Happy to add anything if needed though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard click-through filter uses hidden "testCategory" column instead of "testSubType", returning empty Test Results

1 participant