Skip to content

NXT-15426: Remove redundant/ irrelevant screenshot tests#376

Open
dan-ichim-lgp wants to merge 9 commits into
developfrom
feature/NXT-15426-smoke
Open

NXT-15426: Remove redundant/ irrelevant screenshot tests#376
dan-ichim-lgp wants to merge 9 commits into
developfrom
feature/NXT-15426-smoke

Conversation

@dan-ichim-lgp

@dan-ichim-lgp dan-ichim-lgp commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

NXT-15426 — Refactor Limestone screenshot test scenarios into a maintainable, smoke-oriented structure and reduce redundant derived cases (focus, RTL, large text) without dropping QWTC coverage.

The full screenshot suite had grown large and repetitive: the same configurations were copied across LTR, focus, RTL, and locale blocks. This PR reorganizes scenarios per component, uses shared helpers, and trims duplicate definitions while keeping one representative case per visually distinct configuration.

Resolution

  1. Structural refactor — 55 files under tests/screenshot/apps/components/:

Group scenarios into named arrays (e.g. buttonSmokeTests, buttonCommentedTests, buttonQwtcTests, focus/RTL/locale variants).
Shared helpers in utils.js: withConfig, withProps, pick, LoremString, LongerLoremString.
QWTC-documented cases kept with Jira annotations.
Lower-priority permutations moved into *CommentedTests where appropriate (still exported where not yet trimmed).

  1. Smoke deduplication — net ~−1,700 lines vs develop:

pick(tests, …indices) selects smoke representatives for RTL, large text, and similar derived suites.
Focus tests keep distinct scenario titles (e.g. Focused Update, Hello Focused CheckboxItem) — same convention as develop. Screenshot titles are derived from props/children only; focus: true is not part of the title, so reusing smoke JSX under withConfig({focus: true}) would compare against the wrong Nebula reference when REFERENCE=develop.
Fixed focus/QWTC alignment in CheckboxItem, Chip, Chips, ProgressButton, SwitchItem (QWTC cases back inside withConfig({focus: true}, …)).

  1. PageViews fix — correct RTL scenario selection (pick from commented scenarios where smoke indices were wrong).

Example (Chip.js): smoke list defines visual variants once; focus uses a small dedicated list (Focused Default Chip, …); large text uses pick() from smoke where titles remain unique per skin variant.

Additional Considerations

Links

NXT-15426

Comments

Enact-DCO-1.0-Signed-off-by: Dan Ichim (dan.ichim@lgepartner.com)

@dan-ichim-lgp dan-ichim-lgp changed the title Feature/nxt 15426 smoke NXT-15426: Remove redundant/ irrelevant screenshot tests Jun 15, 2026
@dan-ichim-lgp dan-ichim-lgp self-assigned this Jun 15, 2026
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.54%. Comparing base (e90fa49) to head (ea48605).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #376   +/-   ##
========================================
  Coverage    82.54%   82.54%           
========================================
  Files          153      153           
  Lines         7579     7581    +2     
  Branches      2298     2298           
========================================
+ Hits          6256     6258    +2     
  Misses        1029     1029           
  Partials       294      294           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dan-ichim-lgp dan-ichim-lgp force-pushed the feature/NXT-15426-smoke branch 2 times, most recently from 1728059 to 7459e72 Compare June 15, 2026 14:38
@dan-ichim-lgp dan-ichim-lgp force-pushed the feature/NXT-15426-smoke branch from 2f9e02a to e81bb3c Compare June 23, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant