NXT-15426: Remove redundant/ irrelevant screenshot tests#376
Open
dan-ichim-lgp wants to merge 9 commits into
Open
NXT-15426: Remove redundant/ irrelevant screenshot tests#376dan-ichim-lgp wants to merge 9 commits into
dan-ichim-lgp wants to merge 9 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #376 +/- ##
========================================
Coverage 82.54% 82.54%
========================================
Files 153 153
Lines 7579 7581 +2
Branches 2298 2298
========================================
+ Hits 6256 6258 +2
Misses 1029 1029
Partials 294 294 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1728059 to
7459e72
Compare
2f9e02a to
e81bb3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
NXT-15426 — Refactor Limestone screenshot test scenarios into a maintainable, smoke-oriented structure and reduce redundant derived cases (focus, RTL, large text) without dropping QWTC coverage.
The full screenshot suite had grown large and repetitive: the same configurations were copied across LTR, focus, RTL, and locale blocks. This PR reorganizes scenarios per component, uses shared helpers, and trims duplicate definitions while keeping one representative case per visually distinct configuration.
Resolution
Group scenarios into named arrays (e.g. buttonSmokeTests, buttonCommentedTests, buttonQwtcTests, focus/RTL/locale variants).
Shared helpers in utils.js: withConfig, withProps, pick, LoremString, LongerLoremString.
QWTC-documented cases kept with Jira annotations.
Lower-priority permutations moved into *CommentedTests where appropriate (still exported where not yet trimmed).
pick(tests, …indices) selects smoke representatives for RTL, large text, and similar derived suites.
Focus tests keep distinct scenario titles (e.g. Focused Update, Hello Focused CheckboxItem) — same convention as develop. Screenshot titles are derived from props/children only; focus: true is not part of the title, so reusing smoke JSX under withConfig({focus: true}) would compare against the wrong Nebula reference when REFERENCE=develop.
Fixed focus/QWTC alignment in CheckboxItem, Chip, Chips, ProgressButton, SwitchItem (QWTC cases back inside withConfig({focus: true}, …)).
Example (Chip.js): smoke list defines visual variants once; focus uses a small dedicated list (Focused Default Chip, …); large text uses pick() from smoke where titles remain unique per skin variant.
Additional Considerations
Links
NXT-15426
Comments
Enact-DCO-1.0-Signed-off-by: Dan Ichim (dan.ichim@lgepartner.com)