format: add the Name context type and guard to the TS types#246
Merged
Conversation
The `name` context has had a schema and spec page, but the TypeScript
types never mirrored it — there was no `Context.Name` interface or
`isName` guard, and `name` was absent from the `Context` union and
`isContext`. Add them, matching the other context guards, so a bare
`{ name }` context is recognized.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
namecontext has had a schema and spec page, but the TypeScript types never mirrored it — there was noContext.Nameinterface orisNameguard, andnamewas absent from theContextunion andisContext. Add them (matching the other context guards), so a bare{ name }context is recognized, plus schema-guard test coverage.