Skip to content

Update Russian (ru) translation - add 129 missing keys#415

Open
maojianian25-png wants to merge 4 commits into
ethereumfollowprotocol:mainfrom
maojianian25-png:update-ru-translation
Open

Update Russian (ru) translation - add 129 missing keys#415
maojianian25-png wants to merge 4 commits into
ethereumfollowprotocol:mainfrom
maojianian25-png:update-ru-translation

Conversation

@maojianian25-png

Copy link
Copy Markdown

Russian Translation Update

This PR adds 129 missing translation keys to the Russian (ru) translation file, bringing it from 167/276 to 276/276 complete.

Changes

  • Added translations for all missing keys including: notifications, swipe UI, keyboard/mouse controls, team page, integrations page, share features, Top 8, and more
  • All crypto-specific terminology properly translated (onchain, wallet, ENS, POAP, etc.)

Bounty Reference

Per https://docs.efp.app/translationbounty/

Reward Info

@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown

@maojianian25-png is attempting to deploy a commit to the EthID Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps

greptile-apps Bot commented Jun 9, 2026

Copy link
Copy Markdown

Greptile Summary

This PR completes the Russian (ru) translation file by adding 129 previously missing keys, bringing coverage from 167/276 to 276/276. Several previously-flagged quality issues (swipe context in connect to see more, mute-verb consistency, "скачано" for downloaded, and the 👀 emoji in feed description) have been addressed in the submitted version.

  • All 129 new keys are present and correctly map to their English counterparts; no English key is still missing from the Russian file.
  • Unnecessary blank lines throughout the JSON are removed, producing cleaner diffs in future edits.
  • One minor grammar gap exists: followersYouKnow.followsThem uses the masculine-only form \"подписан на них\" without the parenthetical gender marker used consistently elsewhere (e.g. \"подписался(-ась)\"), which will produce grammatically incorrect output for female ENS names.

Confidence Score: 5/5

Safe to merge — the change is a pure JSON translation addition with no runtime logic, and all previously identified quality issues appear resolved in the submitted version.

The change touches only a static locale file. All keys in the English reference file are now present in Russian, the JSON is valid, and the translations are accurate. The one remaining note (gender marker on a single key) does not affect functionality or cause wrong data to be displayed in most cases.

No files require special attention beyond the minor gender-agreement note on followersYouKnow.followsThem.

Important Files Changed

Filename Overview
public/locales/ru/translations.json Adds 129 missing translation keys to complete the Russian locale (276/276); also removes spurious blank lines from the JSON. All previously flagged issues (emoji, "скачано", swipe context, mute terminology) appear to have been addressed in subsequent commits. One minor gender-agreement gap remains in followersYouKnow.followsThem.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[English translations.json\n276 keys] -->|compare| B{Key present\nin ru/translations.json?}
    B -->|Yes - 167 existing keys| C[No change needed]
    B -->|No - 129 missing keys| D[Added by this PR]
    D --> E[Notifications\nnot.follow/unfollow/tag/block/mute etc.]
    D --> F[Swipe UI\nswipe title/description, keyboard, mouse]
    D --> G[Pages\nteam, integrations, examples, feed]
    D --> H[Share / Top 8\nShare Your Top 8, Copy, Image downloaded]
    D --> I[Misc UI\nclose, retry, noData, goBack, POAP etc.]
    C --> J[ru/translations.json\n276/276 complete ✓]
    E --> J
    F --> J
    G --> J
    H --> J
    I --> J
Loading

Fix All in Conductor Fix All in Cursor Fix All in Codex Fix All in Claude Code

Reviews (4): Last reviewed commit: "fix: clarify Russian download wording" | Re-trigger Greptile

Comment thread public/locales/ru/translations.json Outdated
Comment thread public/locales/ru/translations.json Outdated
Comment thread public/locales/ru/translations.json Outdated
Comment thread public/locales/ru/translations.json Outdated
Comment thread public/locales/ru/translations.json Outdated
@maojianian25-png

Copy link
Copy Markdown
Author

Thanks for the review. I pushed a follow-up commit addressing the remaining Russian translation feedback and ensured the locale file ends with a trailing newline.

@maojianian25-png

Copy link
Copy Markdown
Author

Thanks for the follow-up review. I pushed a new commit clarifying the three Russian download strings by using скачайте instead of the ambiguous загрузите wording.

@maojianian25-png

Copy link
Copy Markdown
Author

Addressed all Greptile review feedback:

  • Added trailing newline at end of file
  • connect to see more: Added "профили" to preserve swiping context
  • notifications.mute/unmute: Using consistent "игнорировать" terminology
  • Image downloaded: Changed to "скачано" (unambiguous download)
  • feed description: Added 👀 emoji to match source string

Please re-review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant