fix(devtools): enable React rendering analysis and fix large trace parsing#32
Open
f1shy-dev wants to merge 2 commits into
Open
fix(devtools): enable React rendering analysis and fix large trace parsing#32f1shy-dev wants to merge 2 commits into
f1shy-dev wants to merge 2 commits into
Conversation
…gz traces and optimizing lazy Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes three high-impact gaps surfaced during field testing with React traces: large gz trace parsing caused string overflow errors, summary/capability maps required expensive derived layers, and React render timing lacked classification.
Large trace parsing (
src/drivers/devtools.ts).gzfiles to avoid "Cannot create a string longer than 0x1fffffe8 characters" errors on traces >32MB.Lazy summary and capability maps (
src/drivers/devtools.ts)buildSummaryto compute stats directly fromtraceEventsinstead of pulling derived layers.buildCapabilityMapto detect capabilities viatraceEvents.someinstead of materializing dimensions.devtools/views.framePipelineerrored; summary now only depends ondevtools/trace.React render timing (
src/drivers/devtools.ts)normalizeUserTimingNameto strip zero-width spaces from React component names.getRenderMeasureKindto classify measures into component/scheduler/lifecycle/measure based ontrack.kindandtrackGroupcolumns todevtools.views.renderMeasures.devtools.views.renderComponentHotspotsanddevtools.views.interactionRendersto only include rows withcomponentName.Type fix (
src/drivers/nextjs-bundle.ts)argsparameter in namespace route handler.