File error reporting#3103
Open
Prospect138 wants to merge 9 commits into
Open
Conversation
mwestphal
reviewed
May 3, 2026
Member
mwestphal
left a comment
mwestphal
left a comment
There was a problem hiding this comment.
Feel free to request a review whenever needed, top right :)
mwestphal
reviewed
May 3, 2026
|
You are modifying libf3d public API! |
Member
|
@Prospect138 need help moving forward ? |
Prospect138
force-pushed
the
feature/file_error_reporting
branch
from
b4e350c to
acc5d29
Compare
mwestphal
reviewed
May 29, 2026
mwestphal
reviewed
May 29, 2026
mwestphal
reviewed
May 29, 2026
mwestphal
reviewed
May 29, 2026
mwestphal
reviewed
May 29, 2026
Member
|
Looks ok to me. I agree with your suggestion of moving the enum to the |
mwestphal
reviewed
May 29, 2026
mwestphal
requested changes
May 29, 2026
Member
mwestphal
left a comment
mwestphal
left a comment
There was a problem hiding this comment.
on quick look, one change needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add distinguish between a file of unsupported extension and a file of unsupported content on f3d load.
WIP
Issue ticket number and link if any
#3000
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.