Skip to content

Fix text layout cache key for maxFontSizeMultiplier#56960

Open
KirtiRamchandani wants to merge 1 commit into
facebook:mainfrom
KirtiRamchandani:fix/text-cache-max-font-size-multiplier
Open

Fix text layout cache key for maxFontSizeMultiplier#56960
KirtiRamchandani wants to merge 1 commit into
facebook:mainfrom
KirtiRamchandani:fix/text-cache-max-font-size-multiplier

Conversation

@KirtiRamchandani
Copy link
Copy Markdown

Summary:

Text layout measurement cache keys currently consider fontSizeMultiplier and allowFontScaling, but omit maxFontSizeMultiplier. When that cap changes, Fabric can reuse a stale measurement even though the effective scaled font size may change.

This adds maxFontSizeMultiplier to the layout-wise text attribute equality and hash helpers, and covers the cache-key behavior with focused C++ tests.

Fixes #56921.

Changelog:

[GENERAL] [FIXED] - Include maxFontSizeMultiplier in Fabric text layout cache keys.

Test Plan:

  • npx --yes clang-format --dry-run --Werror packages/react-native/ReactCommon/react/renderer/textlayoutmanager/tests/TextLayoutManagerTest.cpp
  • git diff --check

I could not run the native gtest target locally from this sparse checkout; the patch adds focused coverage in the existing TextLayoutManagerTest.cpp file.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 25, 2026

Hi @KirtiRamchandani!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 25, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 25, 2026
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 25, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text layout cache isn't invalidated when maxFontSizeMultiplier changes

1 participant